Add method to the JQuery ajax request #692
Conversation
I would recommend adding the method to make the ajax request clearer
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
|
The JSONP transport uses a script tag, so it always performs a GET. Actually showing that in the example may actually confuse things more and make people think other methods like POST are possible when they are not. Perhaps the text could be clarified elsewhere? |
|
Can you please also take a look at the CLA error? :) |
|
Hi, @dmethvin You are right. I can remove this PR if you think its not needed |
Just signed the CLA
|
It doesn't look needed to me. I'm not sure how alive YQL is these days either, their forum has gone missing and the last activity on the YQL blog is 2013. In this industry it's hard to find stuff that doesn't break after a few years! According to the error message (click Details), it looks like the name on the commit still isn't right. you need to change your git info on your computer, see the instructions in Details. If we aren't going to land it though, that's fine. If you see something else that needs fixing and have fixed your git signature, everything should be fine with subsequent commits. |
I would recommend adding the method to make the ajax request clearer