Traversing: Fix `contents()` on `<object>`s with children

(cherry-picked from 4d865d9) Fixes gh-4384 Closes gh-4385
jquery · May 6, 2019 · 42badf34607092fd754a18f5b71e9b08457f982a · 42badf3
1 parent 0e3e23d
commit 42badf34607092fd754a18f5b71e9b08457f982a
Unified Split

Showing with 14 additions and 1 deletion.

+1 −1 src/traversing.js

+13 −0 test/unit/traversing.js
diff --git a/src/traversing.js b/src/traversing.js
@@ -145,7 +145,7 @@ jQuery.each( {
 		return siblings( elem.firstChild );
 	},
 	contents: function( elem ) {
-		if ( typeof elem.contentDocument !== "undefined" ) {
+		if ( elem.contentDocument != null ) {
 			return elem.contentDocument;
 		}
 

diff --git a/test/unit/traversing.js b/test/unit/traversing.js
@@ -808,6 +808,19 @@ QUnit.test( "contents() for <object />", function( assert ) {
 	jQuery( "#qunit-fixture" ).append( svgObject );
 } );
 
+QUnit.test( "contents() for <object /> with children", function( assert ) {
+	assert.expect( 1 );
+
+	var object = "<object type='application/x-shockwave-flash' width='200' height='300' id='penguin'>" +
+		"<param name='movie' value='flash/penguin.swf'>" +
+		"<param name='quality' value='high'>" +
+		"<img src='images/penguin.jpg' width='200' height='300' alt='Penguin'>" +
+	"</object>";
+
+	var contents = jQuery( object ).contents();
+	assert.equal( contents.length, 3, "Check object contents children are correct" );
+} );
+
 QUnit.test( "contents() for <frame />", function( assert ) {
 	assert.expect( 2 );