Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a memory problem about deferred in 3.x #3606

Closed
houfeng0923 opened this issue Apr 2, 2017 · 1 comment
Closed

a memory problem about deferred in 3.x #3606

houfeng0923 opened this issue Apr 2, 2017 · 1 comment
Assignees
@jbedard
Labels
Deferred
Milestone
3.3.0

Comments

@houfeng0923
Copy link

@houfeng0923 houfeng0923 commented Apr 2, 2017

Description

When our project upgraded to jQuery3.2.1 (from 2.2.4), we found a memory leak about Deferred in jQuery3.x . the promise.then method does not release the handler & handler Closure .
it work well in jQuery2.x and native Promise in chrome .

look at the following case：

Link to test case

http://plnkr.co/edit/DpMkLV2mqzwlX4Ruuk7i

image

image
@houfeng0923 houfeng0923 changed the title a memory problem about deferred in jQuery3.x a memory problem about deferred in 3.x Apr 3, 2017
@timmywil timmywil added this to the 3.3.0 milestone Apr 10, 2017
@jbedard jbedard self-assigned this May 1, 2017
@jbedard
Copy link
Contributor

@jbedard jbedard commented May 4, 2017

Here's a version with non-minified jQuery: https://plnkr.co/edit/SE4DMFg8g3SGqDdhxCXx

big-deferred
jbedard added a commit to jbedard/jquery that referenced this issue May 4, 2017
@jbedard
Deferred: fix memory leak of promise callbacks
00e0c7a 
Fixes jquerygh-3606
@jbedard jbedard mentioned this issue May 4, 2017
Merged
jbedard added a commit to jbedard/jquery that referenced this issue May 5, 2017
@jbedard
Deferred: fix memory leak of promise callbacks
7f14fdf 
Fixes jquerygh-3606
jbedard added a commit to jbedard/jquery that referenced this issue May 9, 2017
@jbedard
Deferred: fix memory leak of promise callbacks
c167f0a 
Fixes jquerygh-3606
jbedard added a commit to jbedard/jquery that referenced this issue Jun 9, 2017
@jbedard
Deferred: fix memory leak of promise callbacks
b24e073 
Fixes jquerygh-3606
jbedard added a commit to jbedard/jquery that referenced this issue Jun 13, 2017
@jbedard
Deferred: fix memory leak of promise callbacks
c50bd68 
Fixes jquerygh-3606
Closes jquerygh-3657
jbedard added a commit to jbedard/jquery that referenced this issue Jun 14, 2017
@jbedard
Deferred: fix memory leak of promise callbacks
c1cfb3a 
Fixes jquerygh-3606
Closes jquerygh-3657
gibson042 added a commit that referenced this issue Jun 20, 2017
@jbedard @gibson042
Deferred: fix memory leak of promise callbacks
Loading status checks…
3638928 
Fixes gh-3606
Closes gh-3657
@GulajavaMinistudio GulajavaMinistudio mentioned this issue Jun 20, 2017
Merged
4 tasks
mvilliger added a commit to bsi-software/org.eclipse.scout.docs that referenced this issue May 2, 2018
@mvilliger
Update jQuery to version 3.3.1
04df6a4 
Especially fixes for jquery/jquery#3808 and
jquery/jquery#3606 are important.

Full change log can be found here:
http://blog.jquery.com/2018/01/19/jquery-3-3-0-a-fragrant-bouquet-of-deprecations-and-is-that-a-new-feature/
@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jbedard jbedard

Labels
Deferred
Projects
None yet
Milestone
3.3.0
Linked pull requests

Successfully merging a pull request may close this issue.

Deferred: fix memory leak of promise callbacks
4 participants
@jbedard @timmywil @markelog @houfeng0923