Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: All tests fail (timeout) on Android 4.0 #3743

Closed
Krinkle opened this issue Jul 31, 2017 · 3 comments
Closed

Regression: All tests fail (timeout) on Android 4.0 #3743

Krinkle opened this issue Jul 31, 2017 · 3 comments
Assignees
@timmywil
Labels
Blocker Has Pull Request
Milestone
3.3.0

Comments

@Krinkle
Copy link
Member

@Krinkle Krinkle commented Jul 31, 2017 •
edited

Before After
Commit 3638928 Commit 31783e6
swarm.jquery.org, 24 Jun 2017 swarm.jquery.org, 27 Jun 2017
screen shot screen shot

screen shot

Possibly relevant commits:

According to code review comments, this commit also affected IE8/IE9 in some way. (@mgol)
@mgol mgol mentioned this issue Jul 31, 2017
Closed
@mgol
Copy link
Member

@mgol mgol commented Aug 1, 2017

Sometimes such breakages are caused by changes on the BrowserStack side but I've re-run tests on the commit you mentioned and the one before that and results were identical.

So we broke something, indeed.

Marking as a blocker for 3.3.0.
@mgol
Copy link
Member

@mgol mgol commented Aug 1, 2017

Thanks, @Krinkle!
@mgol mgol added this to the 3.3.0 milestone Aug 1, 2017
@mgol mgol added the Blocker label Aug 1, 2017
mgol referenced this issue Aug 1, 2017
@CDAGaming @timmywil
Build: update node dependencies; commit package-lock.json
Verified
This commit was signed with the committer’s verified signature.
timmywil Timmy Willison
GPG key ID: 5F0C8B73EF56CE6F Learn about vigilant mode.
Loading status checks…
31783e6 
- Also ignore yarn.lock
Close gh-3669
mgol added a commit to mgol/jquery that referenced this issue Aug 16, 2017
@mgol
Build: Fix UglifyJS output in Android 4.0
fa0e0ce 
Enabling the ie8 option makes Android 4.0 run tests properly. Before that it
wasn't rendering anything in the QUnit iframe.

Fixes jquerygh-3743
@mgol mgol mentioned this issue Aug 16, 2017
Closed
2 tasks done
@mgol
Copy link
Member

@mgol mgol commented Aug 16, 2017 •
edited

I've created a PR fixing this but at a significant cost: #3759.

It may be a good basis to look for the real problem.
@timmywil timmywil self-assigned this Dec 11, 2017
timmywil added a commit to timmywil/jquery that referenced this issue Jan 3, 2018
@timmywil
Build: Fix UglifyJS output in Android 4.0; update uglify
Verified
This commit was signed with the committer’s verified signature.
timmywil Timmy Willison
GPG key ID: 5F0C8B73EF56CE6F Learn about vigilant mode.
985248d 
Fixes jquerygh-3743
timmywil added a commit to timmywil/jquery that referenced this issue Jan 3, 2018
@timmywil
Build: Fix UglifyJS output in Android 4.0; update uglify
Verified
This commit was signed with the committer’s verified signature.
timmywil Timmy Willison
GPG key ID: 5F0C8B73EF56CE6F Learn about vigilant mode.
cf90b4b 
Fixes jquerygh-3743
timmywil added a commit to timmywil/jquery that referenced this issue Jan 3, 2018
@timmywil
Build: Fix UglifyJS output in Android 4.0; update uglify
Verified
This commit was signed with the committer’s verified signature.
timmywil Timmy Willison
GPG key ID: 5F0C8B73EF56CE6F Learn about vigilant mode.
32147a5 
Fixes jquerygh-3743
@timmywil timmywil mentioned this issue Jan 3, 2018
Closed
4 tasks done
@timmywil timmywil closed this in c9efd11 Jan 8, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timmywil timmywil

Labels
Blocker Has Pull Request
Projects
None yet
Milestone
3.3.0
Linked pull requests

Successfully merging a pull request may close this issue.

Build: Fix UglifyJS output in Android 4.0
Build: Fix UglifyJS output in Android 4.0; update uglify
3 participants
@Krinkle @timmywil @mgol