Context Navigation

← Previous Ticket
Next Ticket →

#4087 closed bug (fixed)

insertAfter, insertBefore, etc do not work when destination is original element

Reported by:	XASD	Owned by:
Priority:	low	Milestone:	1.9
Component:	manipulation	Version:	1.6b1
Keywords:		Cc:
Blocked by:		Blocking:

Description

If you do $("#x").insertBefore("#x") element removed entirely from DOM.It seems somehow related to using dom fragments. Version 1.2.6 of jquery work as expected(preserve element on the same place)+it has "reverse" parameter for domManip() used in "after" method,but 1.3.1 does not have one.Is there logical error here?

Thanks.

Change History (23)

comment:1 in reply to: description Changed 13 years ago by XASD

Sorry,I mean $("#x").insertAfter("#x") don't know about insertBefore.

comment:2 Changed 13 years ago by dmethvin

Owner:	set to john

I see what you mean about the documentFragment stuff. Since jQuery.domManip passes in a fragment, jQuery.clean moves #x to the fragment. Later when it gets to the callback in jQuery.after, the original parentNode is gone.

So how did you come up with this case? Is there some more complex code where you end up trying to insert a node after itself?

comment:3 Changed 13 years ago by XASD

<ul id="m">
	<li class="hl">
		<div>c1</div>
		h1
	</li>
	<li>
		<div>c2</div>
		h2
	</li>
</ul>

$("#m div").insertAfter("#m li:first-child div:last-child");//combine in 1

Thanks.

comment:4 Changed 13 years ago by XASD

1.3.2 still not resolved.

Regards.

comment:5 Changed 13 years ago by katbailey

Just wanted to report that this same issue is causing a problem in Drupal's tabledrag functionality, though in our case it's insertBefore - here's a link to the issue on drupal.org: http://drupal.org/node/350275

comment:10 in reply to: description Changed 12 years ago by XASD

JQuery 1.4.2 bug is still there.

comment:11 Changed 11 years ago by dmethvin

Milestone:	1.3.2 → 1.5
Status:	new → open

comment:12 Changed 11 years ago by snover

Owner:	changed from john to XASD
Status:	open → pending

Could you please confirm this bug still exists using the jQuery 0 GIT version of jQuery on jsFiddle? If it does not, please provide a link to the testcase.