Skip to content

/ jquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply same fix to radio buttons as for checkbox #3423

Closed
mbest opened this issue Dec 2, 2016 · 10 comments
Closed

Apply same fix to radio buttons as for checkbox #3423

mbest opened this issue Dec 2, 2016 · 10 comments
Assignees
@gibson042
Labels
Blocker Event Has Pull Request
Milestone
3.4.0

Comments

@mbest
Copy link

@mbest mbest commented Dec 2, 2016

See https://bugs.jquery.com/ticket/3827 and 1fb2f92

This fix should also include radio buttons. Currently if you use jQuery to trigger a click on a radio button, event handlers get called before the checked state is updated. The release notes for 1.9.1 when the above change was included say it was changed for radio buttons even though it wasn't.
@mbest mbest mentioned this issue Dec 2, 2016
Closed
@gibson042
Copy link
Member

@gibson042 gibson042 commented Dec 5, 2016

Yes, we appear to have a problem in

jquery/src/event.js

Line 477 in f18ca7b

// For checkbox, fire native event so checked state will be right

using this.type === "checkbox" instead of rcheckableType.test( this.type ).
@markelog
Copy link
Member

@markelog markelog commented Dec 5, 2016

Hi there.

I think we understand what you mean, but would you mind providing a test-case on http://jsbin.com/ or on similar resource? So it would be clear what behaviour you expect
@gibson042
Copy link
Member

@gibson042 gibson042 commented Dec 5, 2016

Such test case will also be necessary for a PR. Would you like to work on this, @mbest?
@mbest
Copy link
Author

@mbest mbest commented Dec 5, 2016

Here is the jsbin that was linked in the Knockout issue: http://jsbin.com/yinare/4/edit?html,js,output
@alexr101 alexr101 mentioned this issue Jan 11, 2017
Closed
2 of 4 tasks
@gibson042 gibson042 closed this in b442aba Jan 19, 2017
gibson042 added a commit that referenced this issue Jan 19, 2017
@alexr101 @gibson042
Event: Add radio click triggering tests
Loading status checks…
5f35b5b 
Ref b442aba
Ref gh-3423
@timmywil timmywil reopened this Mar 20, 2017
@timmywil timmywil added this to the 3.3.0 milestone Mar 20, 2017
@timmywil
Copy link
Member

@timmywil timmywil commented Mar 20, 2017

This will be backed out due to the regression seen here. We will re-land with a fix for that regression in 3.3.
@timmywil
Copy link
Member

@timmywil timmywil commented Mar 20, 2017

Also see #1367
@mbest
Copy link
Author

@mbest mbest commented Mar 20, 2017 •
edited

Seems the same issue would apply to trigger('click') on checkboxes (code that has existed since 1.9.1).
@timmywil
Copy link
Member

@timmywil timmywil commented Mar 21, 2017

Right, but that's not a regression since 3.1.1. We plan to address that as well in 3.3.
@gibson042 gibson042 mentioned this issue Aug 9, 2017
Closed
@timmywil timmywil modified the milestones: 3.3.0, 3.4.0 Jan 16, 2018
@timmywil
Copy link
Member

@timmywil timmywil commented Jan 16, 2018

@gibson042 is working on this, but it will not make it in the 3.3 release.
@mgol mgol mentioned this issue Jul 30, 2018
Closed
gibson042 added a commit to gibson042/jquery that referenced this issue Jan 14, 2019
@alexr101 @gibson042
Event: Trigger checkbox and radio click events identically
eecb078 
(cherry picked from commit b442aba)

Ref jquerygh-3494
Fixes jquerygh-3423
@gibson042 gibson042 mentioned this issue Jan 14, 2019
Closed
3 of 4 tasks
@mgol
Copy link
Member

@mgol mgol commented Jan 27, 2019

PR: #4279
mgol added a commit to gibson042/jquery that referenced this issue Mar 20, 2019
@alexr101 @mgol
Event: Trigger checkbox and radio click events identically
389055d 
(cherry picked from commit b442aba)

Ref jquerygh-3494
Fixes jquerygh-3423
@mgol mgol closed this in 669f720 Mar 20, 2019
@GulajavaMinistudio GulajavaMinistudio mentioned this issue Mar 21, 2019
Merged
4 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gibson042 gibson042

Labels
Blocker Event Has Pull Request
Projects
None yet
Milestone
3.4.0
Linked pull requests

Successfully merging a pull request may close this issue.

Bottom sheet scrolling
Event: Support jQuery extensions for native-backed click events
5 participants
@timmywil @markelog @gibson042 @mbest @mgol