Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typography and Unit Measurement Review and Refactor #172

Open
sfrisk opened this issue Nov 8, 2016 · 3 comments
Open

Typography and Unit Measurement Review and Refactor #172

sfrisk opened this issue Nov 8, 2016 · 3 comments

Comments

@sfrisk
Copy link
Member

@sfrisk sfrisk commented Nov 8, 2016

CSS best practices have changed a bit since we started this project. Along that line I think we should review how we've done typography so far in this project and how we can best refactor it to match best standards. Specifically there is a lot of px useage for size/measurements, and we have a em convertor when we could probably be using rem instead. Same thing holds true with a lot of measurements for components that have been created - overuse of the px measurement unit.
@lunaticmonk
Copy link

@lunaticmonk lunaticmonk commented Jan 5, 2017

We have used em for typography. Can't we used rem for that instead of em? Wouldn't that prove good?
According to me using em would cause problems when 2-3 elements are nested.For example nested unordered lists. Opinions?

@lunaticmonk
Copy link

@lunaticmonk lunaticmonk commented Jan 8, 2017

@sfrisk I am refactoring typography. I want to use rem instead of em. The _typography.scss file has all the values of typography defined in pixels....shall I keep them in pixels as it is? Since the pixel to rem converting function will take care of final conversion to rem format.

@sfrisk
Copy link
Member Author

@sfrisk sfrisk commented Jan 12, 2017

check out https://www.youtube.com/watch?v=XanhwddQ-PM - this shows a lot of the techniques we were planning on applying to typography, and unit measurement in general for Chassis.

@geekman-rohit geekman-rohit mentioned this issue Feb 15, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@sfrisk @lunaticmonk