Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Count Bubble position problem #3979

Closed
azuo opened this issue Apr 6, 2012 · 6 comments
Closed

Count Bubble position problem #3979

azuo opened this issue Apr 6, 2012 · 6 comments
Assignees
Milestone

Comments

@azuo
Copy link
Contributor

azuo commented Apr 6, 2012

count bubble position using 1.1.0.rc1:
http://jsfiddle.net/7N6Yh/
Everything is OK.

count bubble position using 1.1.0.rc2:
http://jsfiddle.net/7N6Yh/2/
Count bubble overlaps the text in a custom multi-select menu, and is placed too close to the split button in a listview.

@toddparker
Copy link
Contributor

We should touch this up before final. Thanks.

@ghost ghost assigned Wilto Apr 6, 2012
@jaspermdegroot
Copy link
Contributor

@Wilto

Are you or somebody else already working on this? If you like I can create a pull request that fixes those issues. Just let me know.

@toddparker
Copy link
Contributor

I don't believe @Wilto has worked on this yet so if you want to work on a pull request, we'd be happy to give it a look.

@toddparker
Copy link
Contributor

BTW - we've decided to freeze the code and get final out sooner so this will end up landing in the first maintenance release.

@jaspermdegroot
Copy link
Contributor

Azuo used a listview with data-mini="true" in his example. That is not supported (yet) as far as I know.
In my pull request I only enclosed two minor changes that make sure there is no overflow in case of a mini button in listview. So they will look good but for consistency the padding/position should be tweaked. I thought it was better to wait with adding those rules until mini listviews are going to be supported.

Edit: I replaced my original PR's by a new one which also makes listviews compatible with data-mini="true"

@atuttle
Copy link

atuttle commented Apr 18, 2012

I've also noticed that the count bubble is not repositioned in this case (link icon disabled):

<li data-icon="false"><a>Whatever <span class="ui-li-count">55</span></a></li>

I made this change in a custom css file I'm using for my application and it's working well for me, but it's not tested against all possible cases:

li[data-icon=false] .ui-li-count {
    right: 30px;
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants