passing empty object to .before() or .after() throws exception in IE7

[anonymous]

The following line:

$( '.hlist dl dl, .hlist ol ol, .hlist ul ul' )

.before( '( ' ).after( ') ' );

Throws an exception in IE7 if the the query returns empty, passing null to before() and .after(). IE8 and other browsers does not have this problem.

[dmethvin]

Thanks for taking the time to contribute to the jQuery project! Please provide a complete reduced test case on jsFiddle to help us assess your ticket!

Additionally, be sure to test against the jQuery Edge version to ensure the issue still exists. To get you started, use this boilerplate: ​http://jsfiddle.net/FrKyN/ Open the link and click to "Fork" (in the top menu) to get started.

[anonymous]

Adding jFiddle: ​http://jsfiddle.net/5m6et/

[anonymous]

​http://jsfiddle.net/5m6et/1/

Hope this one works.

[timmywil]

Confirmed. ​http://jsfiddle.net/5m6et/4/

[dmethvin]

It's actually failing everywhere, you can see the console error thrown by Sizzle.error in Chrome for example. It's a simple fix so I'll get it now.

[anonymous]

I discovered indeed it happens in all browsers. The problem is in combination with the text passed ("( "). Passing "<span>( </span>" instead does not fail.

[anonymous]

It appears to happen on any combination of characters (brackets and operators) that have any meaning in javascript. "*" is especially fun... .append() and .prepend() are not affected.

The best fix is to not do anything when applied to null.

[Dave Methvin]

Fix #10812, let .before() and .after() work on empty collections.

Changeset: dd845a2c0f63f97e74e4d490ee66e12e0bf180c5