Skip to content

/ pure

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Updated Gruntfile after pure-css#705. #820

Merged
merged 1 commit into from Oct 18, 2020
Merged

chore: Updated Gruntfile after pure-css#705. #820

merged 1 commit into from Oct 18, 2020

Conversation

@medianect
Copy link
Contributor

@medianect medianect commented Oct 18, 2020

The name of the license text file was changed but not references to it in Gruntfile.js, resulting into invalid link in compiled versions headers.
@medianect
chore: Updated Gruntfile after #705.
Loading status checks…
a83fa66
@medianect
Copy link
Contributor Author

@medianect medianect commented Oct 18, 2020

An example will be better than my hard to parse sentence. Here is the header in actual released files (note the .md at the end of license URL):

/*!
Pure v2.0.3
Copyright 2013 Yahoo!
Licensed under the BSD License.
https://github.com/pure-css/pure/blob/master/LICENSE.md
*/

Whereas it is after that PR https://github.com/pure-css/pure/blob/master/LICENSE.
@redonkulus redonkulus merged commit e79bd2f into pure-css:master Oct 18, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redonkulus
Copy link
Contributor

@redonkulus redonkulus commented Oct 18, 2020

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@medianect @redonkulus
You can’t perform that action at this time.