Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove event.which property fill #3235

Closed
dmethvin opened this issue Jul 15, 2016 · 4 comments
Closed

Remove event.which property fill #3235

dmethvin opened this issue Jul 15, 2016 · 4 comments
Assignees
@mgol
Labels
Event Has Pull Request
Milestone
3.6.0

Comments

@dmethvin
Copy link
Member

@dmethvin dmethvin commented Jul 15, 2016

IE8 seems to be the last browser that didn't provide this natively. It's a bit tricky to test because it needs a real event and not a simulated one.

#3233 (comment)

See also gh-2337, if we're not filling the property and just passing it on I don't know that we need to formally deprecate it in jQuery or generate a Migrate warning. If browsers ever tried to deprecate it via a console warning, the pass-through we do when copying the property would be the responsibility of the caller. If anything I'd say we add a note in our docs to use event.button or event.buttons where possible.
@dmethvin dmethvin added this to the 3.2.0 milestone Jul 15, 2016
@markelog markelog mentioned this issue Jul 15, 2016
Merged
4 tasks
@timmywil timmywil added the Event label Jul 15, 2016
@dmethvin dmethvin mentioned this issue Aug 14, 2016
Open
8 tasks
@timmywil timmywil assigned dmethvin and gibson042 and unassigned gibson042 Sep 26, 2016
@timmywil timmywil removed this from the 3.2.0 milestone Mar 6, 2017
@timmywil timmywil added this to the 3.3.0 milestone Mar 6, 2017
@timmywil timmywil added this to the 3.3.0 milestone Mar 6, 2017
@timmywil timmywil removed this from the 3.2.0 milestone Mar 6, 2017
@timmywil timmywil mentioned this issue May 15, 2017
Closed
@timmywil timmywil removed this from the 3.3.0 milestone Jun 19, 2017
@timmywil timmywil added this to the 4.0.0 milestone Jun 19, 2017
@timmywil timmywil added this to the 4.0.0 milestone Jun 19, 2017
@timmywil timmywil removed this from the 3.3.0 milestone Jun 19, 2017
@dmethvin dmethvin mentioned this issue Jan 9, 2018
Closed
@mgol mgol mentioned this issue Jul 29, 2020
Merged
4 tasks
mgol added a commit to mgol/jquery that referenced this issue Jul 29, 2020
@mgol @mgol
Event: Remove the event.which shim
a684919 
All supported browsers implement this property by themselves. The shim was only
needed for IE <9.

Fixes jquerygh-3235
Ref jquerygh-4755
@mgol
Copy link
Member

@mgol mgol commented Jul 29, 2020

PR: #4765

@mgol
Copy link
Member

@mgol mgol commented Jul 29, 2020

Why is this marked as a behavior change if all the browsers already support it?

@mgol mgol assigned mgol and unassigned dmethvin Jul 29, 2020
@mgol
Copy link
Member

@mgol mgol commented Jul 29, 2020

@dmethvin Sorry, I didn't notice this issue & your assignment before I made the PR. I reassigned the issue to myself.

@dmethvin
Copy link
Member Author

@dmethvin dmethvin commented Jul 31, 2020

@mgol No problem, thanks for doing it! Should just be a case of deleting the which entry in event.js, I wouldn't think it changes any tests.

@mgol mgol removed this from the 4.0.0 milestone Aug 25, 2020
@mgol mgol added this to the 3.6.0 milestone Aug 25, 2020
@mgol mgol closed this in #4765 Aug 26, 2020
mgol added a commit that referenced this issue Aug 26, 2020
@mgol @mgol
Event: Remove the event.which shim
1a5fff4 
All supported browsers implement this property by themselves. The shim was only
needed for IE <9.

Fixes gh-3235
Closes gh-4765
Ref gh-4755
mgol added a commit that referenced this issue Aug 26, 2020
@mgol @mgol
Event: Remove the event.which shim
2bf9793 
All supported browsers implement this property by themselves. The shim was only
needed for IE <9.

Fixes gh-3235
Closes gh-4765
Ref gh-4755

(cherry picked from commit 1a5fff4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgol mgol

Labels
Event Has Pull Request
Projects
None yet
Milestone
3.6.0
Linked pull requests

Successfully merging a pull request may close this issue.

Event: Remove the event.which shim
4 participants
@dmethvin @timmywil @gibson042 @mgol