Improve public API #5526
Merged
Improve public API #5526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
public-api
branch
4 times, most recently
from
2124c06 to
47c89fc
Compare
This can contain all of the `public` functions we want to expose. This will be a bit nicer for example when you want to use internal/private functions (we use some in the vscode intellisense plugin).
This will use the resolveConfig we expose from the `public` folder. We can probably generate these as well.
RobinMalfait
force-pushed
the
public-api
branch
from
47c89fc to
7f1945b
Compare
This should be tested in its own repo instead.
The build step is not a prerequisite anymore for running the tests. When we want to release a new (insiders) release, the `prepublishOnly` step will be executed for us. Before this change, it would have been executed twice: - Once before the tests - Once before the actual release
Now that we can use `SWC`, automatically generating the plugin list before running the tests is super fast and you don't even have to think about it anymore!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
publicfolder inside thesrcfolder. The idea here is that the files inside the./src/publicfolder will eventually be "public" API. The files inside the./src/publicfolder are written inESM. This means that internally if we need those public files, we can then include them from there.The files in the root will include them from the compiled
./lib/publicfolder.The advantage here is:
pretestscript now, so you don't need to think about that!