Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make version number dynamic in integration tests #6017

Merged
merged 1 commit into from Nov 8, 2021

Conversation

@RobinMalfait
Copy link
Contributor

@RobinMalfait RobinMalfait commented Nov 8, 2021

Every time we release a new version, the integration tests start failing. This
is because we have a CLI test where we look at the output of the tailwindcss --help output.

This output contains a version number, that will be out of date when we release a new version.

This PR fixes that by making the version dynamic based on the package.json
version value. This should be safe to do because the goal of the tests is
ensuring that the CLI help output is consistent, not so much the version
number. BUT it is still important that the version is in sync. This will ensure
it is always in sync.

@RobinMalfait RobinMalfait merged commit ac5a204 into master Nov 8, 2021
10 checks passed
@RobinMalfait RobinMalfait deleted the fix-version-in-tests branch Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant