Skip to content

/ animate.css

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly update to postCSS v8 #1204

Open
eltonmesquita opened this issue Dec 31, 2020 · 6 comments
Open

Properly update to postCSS v8 #1204

eltonmesquita opened this issue Dec 31, 2020 · 6 comments
Assignees
@WarenGonzaga
Labels
feature request good first issue improvement

Comments

@eltonmesquita
Copy link
Collaborator

@eltonmesquita eltonmesquita commented Dec 31, 2020

Recently we updated to postCSS v8 which brings lots of changes, including how to use it and its "plugins" as dependencies in the project. Right now the building system is working but it's throwing some warn as we're not following the recommendations.

We need to fix this and get #1194 merged so everything is working nicely and in the best way possible. Help is very welcomed!
@WarenGonzaga
Copy link
Member

@WarenGonzaga WarenGonzaga commented Dec 31, 2020

I just pull the changes... and try to fix this.
@eltonmesquita
Copy link
Collaborator Author

@eltonmesquita eltonmesquita commented Dec 31, 2020

@WarenGonzaga , shout out if you need any help on this, alright?
@WarenGonzaga
Copy link
Member

@WarenGonzaga WarenGonzaga commented Dec 31, 2020

@WarenGonzaga , shout out if you need any help on this, alright?

I don't see any errors on compiling.
@eltonmesquita
Copy link
Collaborator Author

@eltonmesquita eltonmesquita commented Dec 31, 2020

Work on #1194 branch and you can see the warnings. Also, if you read postCSS docs/migration guide you'll see that it doesn't use plugins anymore even though they are supported. A bit weird but makes sense with what they're doing now.
@eltonmesquita
Copy link
Collaborator Author

@eltonmesquita eltonmesquita commented Dec 31, 2020

BTW, Happy New Year @WarenGonzaga 🍾 🥂 🎉 ! Thanks for all the effort you've put in the library!
@WarenGonzaga
Copy link
Member

@WarenGonzaga WarenGonzaga commented Dec 31, 2020

BTW, Happy New Year @WarenGonzaga 🍾 🥂 🎉 ! Thanks for all the effort you've put in the library!

Happy New Year too! No problem... small effort.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WarenGonzaga WarenGonzaga

Labels
feature request good first issue improvement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@eltonmesquita @WarenGonzaga