Opened 12 years ago
Closed 11 years ago
#7974 closed enhancement (fixed)
Cleanup effects.js to improve performances and reduce filesize
| Reported by: | lrbabe | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | 1.6 |
| Component: | effects | Version: | 1.4.4 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
I've opened a pull request of small changes to effect.js that:
- reduce function calls, jQuery.now() calls in particular
- reduce number of out-of-scope variables lookups
- cache more variables to reduce file-size once minified
It yields some interesting performance improvement, as demonstrated in this example: http://jsfiddle.net/louisremi/V3Xqt/5/ (remove patched effects.js in "manage ressources" menu to see the difference)
- function calls: 1177 -> 1022 = 13% better
- average execution time: 26.1 -> 23.4 = 10% better
/!\ example might be unrealistic /!\
As a side effect, it keeps animations synchronized and thus fixes #7917 and addresses a similar problem to #6281
Change History (4)
comment:1 Changed 12 years ago by
| Component: | unfiled → effects |
|---|---|
| Milestone: | 1.next → 1.6 |
| Priority: | undecided → low |
| Type: | bug → enhancement |
comment:2 Changed 12 years ago by
| Status: | new → open |
|---|
comment:3 Changed 12 years ago by
comment:4 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | open → closed |
This particular pull request was closed - a new open was opened up (and closed) just recently.
Note: See
TracTickets for help on using
tickets.

Additional benefits with last commits: