Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with UA string of the Microsoft Edge #2357

Closed
markelog opened this issue May 28, 2015 · 2 comments
Closed

Deal with UA string of the Microsoft Edge #2357

markelog opened this issue May 28, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@markelog
Copy link
Member

As noted by the @dmethvin.

See https://msdn.microsoft.com/en-us/library/hh869301%28v=vs.85%29.aspx

Since our tests (mostly support tests) depends on that.

@mgol
Copy link
Member

mgol commented Jun 14, 2015

Hmm, it seems I partially took care of it via 8e111df.

See also #2390 for a summary of where we're staying with MS Edge.

@mgol
Copy link
Member

mgol commented Jun 22, 2015

I've search the code from master and, apart from test/unit/support.js the event originalEvent test is the only place where we sniff for Chrome. In other places we only sniff for:

  1. Android
  2. iOS
  3. Firefox (in one place, to disable focus tests).

No Chrome & IE. Therefore, the originalEvent test is the only place that's left to change (as you said, only the test description & message should be changed to include Edge).

That seems to be it.

@mgol mgol added the Build label Sep 8, 2015
@mgol mgol self-assigned this Sep 8, 2015
@mgol mgol added this to the 3.0.0 milestone Sep 8, 2015
@mgol mgol closed this as completed in 64fd7ef Sep 14, 2015
mgol added a commit that referenced this issue Sep 14, 2015
All other cases where Edge user agent needed to be taken into account
in tests have already been resolved.

(cherry-picked from 64fd7ef)

Fixes gh-2357
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

3 participants