replaceWith() doesn't clone elements where required

[[email protected]…]

(from ​https://github.com/jquery/jquery/pull/920)

I thought I'd try jQuery over the new ​comprehensive test suite we have for the various insertion methods in ​Bonzo and discovered that jQuery's replaceWith() wasn't properly cloning where required.

Inside replaceWith() this.each() is used which then passes a singular collection for each element in this to before() or append() which then invokes domManip(), the clone check inside domManip() (see iNoClone = results.cacheable || l - 1 -- l always == 1).

[timmywil]

Thanks for writing tests in the pull! Just for clarity's sake, do you have a fiddle somewhere that also demonstrates the problem?

[[email protected]…]

@timmywil: this should do it: ​http://jsfiddle.net/fHhKf/4/

[dmethvin]

See additional discussion in ​https://github.com/jquery/jquery/pull/920

[Rick Waldron]

#13001 is a duplicate of this ticket.

[Rod Vagg]

Fixes #12449. make replaceWith() clone elements where required. Closes gh-920

Changeset: 551c2c9f4ac776b6d53600c452ad40a4b4d6670b