New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Sass #277
Switch to Sass #277
Conversation
|
I have made a sass library and a pull request for it https://github.com/sp90/animate.css, its using native scss |
|
If there's anything (code or features) of use in my Sass port of the library, feel free to use any of it. Happy to contribute; https://github.com/benhodgson87/animate.scss |
|
Do we need a less version for it ? |
|
Less version can be useful. Now I had to set flag (less) to properly import css file of Animate. |
|
I like @benhodgson87's one, looks like my one if I'd bothered to keep it up-to-date! Thumbs up for:
Still think these mixins might come in handy though: |
More fluid animations
|
I think it would be ideal to add autoprefixer to this version. Support from browsers changes very often, so it's best to let the autoprefixer take care of it. See more |
|
SCSS would be great, but autoprefixer is usually handled globally, so no real reason to add this. |
|
Yes, there is no need to add prefixes thanks to PostCSS and https://github.com/postcss/autoprefixer. |
This comment has been minimized.
This comment has been minimized.
|
I impulsively made a call here and am now reconsidering. I'm still open to community suggestions about what we'd like to see in a major version of Animate.css. Open source is hard! Thanks everyone (especially @eltonmesquita!) for your contributions and patience. |
|
No need to thanks @daneden ;D. TBH, I think that the considerations you showed when you've sent this PR are still valid. As far as I can say SCSS is still the most used and known pre-processor out there. Although there are some Sass features that could make things easier, I do like the way you kept things simple and easy to understand even for beginners. I vote for this simplicity! Something that's being etching my ears is how we'll deal with this outdated branch. It's not an easy merge, at all. I still don't have a good plan to merge these branches without a massive work and unfortunately ReaLife have not made easy to get proper time to think in details about this. Any suggestion? In the next weeks I'll have lots of free time, so I'll be able to put things in action. |
|
@eltonmesquita and I chatted a bit about this, and along with difficulties to merge this old branch, I think it's safe to say that we can abandon a move to SCSS. The main reasons to do so in the first place were:
In addition to the above, I'm confident that using modern, plain CSS is a much more future-proof option than switching now to Sass and then eventually (likely) once more back to plain CSS. For the time being, I will leave the Sass branch open, and will delete it as we move toward a final 4.0 release. |
|
@daneden I guess the reason for having a Scss version was so that it could toggle the need of keyframes so you don't bloat your project with all the keyframes when they're not needed, but I understand your idea of having it in plain and respect your choice |
|
Hello. I ended up here after searching for "Animate.css Sass"
|
|
Is there a way to use version 4 in my sass files rather than put the code in my html. I know of extend but i know that can and will have adverse effects. Is there another way? |
|
SASS supports CSS imports, so you can just import the files you need directly from the animate.css project. |
|
yes but how do you use animate css library without using @extend. Or must i use extend and if so will it be ok using extend with this library. I have seen other libraries that claim it is ok using extend with their css library. |
|
There should be no problem using extends or just importing the files and using the file names directly in the HTML. You could also create a thin wrapper around it so you can even switch the provided CSS variables through SASS. There's no recommended way for using the library alongside SASS, do what works best for you. If you need more help with this, please use stackoverflow or the likes as this is an issue tracker that is used to report bugs and improvements. You won't get much help about usage around here. |
I’m working through adding some Sass functionality to Animate.css and using it as the primary language going forward.
We’ll use this PR to discuss development, potential features, and track progress.
Wishlist item(s) I’d like to explore before merging to master:
[ ] Config options for transformations1
Footnotes
In other words, adding options for relative vs. absolute transformations (relative to the transformed element vs. fixed, absolute transformation values), and adding some sort of scale for absolute transformations (small, medium, large, extra large, etc.)↩