Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select.val(newValue) doesn't work in IE10 if option contents have leading/trailing spaces #1902

Closed
mgol opened this issue Dec 4, 2014 · 2 comments · Fixed by #1901
Closed

select.val(newValue) doesn't work in IE10 if option contents have leading/trailing spaces #1902

mgol opened this issue Dec 4, 2014 · 2 comments · Fixed by #1901
Labels
Attributes Bug
Milestone
1.12.0/2.2.0

Comments

@mgol
Copy link
Member

mgol commented Dec 4, 2014

Example:

jQuery( "<select><option> 2</option></select>" ).val( "2" ).val()

should return "2" and it doesn't in IE10.
@mgol
Copy link
Member Author

mgol commented Dec 4, 2014

This is caused by the fact that the select set valHook is reading option.value without going through the option get valHook.

mgol added a commit to mgol/jquery that referenced this issue Dec 4, 2014
@mgol
Attributes: Use the option val hook in select val hook and simplify it
c97d8ea 
The hook is still defined; not using it could cause issues in IE<11.
Also, IE10 no longer throws when value not set but it still doesn't trim the
value. IE11 has all those issues fixed; support comments are updated.

Fixes jquerygh-1902
Closes jquerygh-1901
@mgol
Copy link
Member Author

mgol commented Dec 4, 2014

PR: #1901

@mgol mgol mentioned this issue Dec 4, 2014
Merged
mgol added a commit to mgol/jquery that referenced this issue Dec 8, 2014
@mgol
Attributes: Use the option val hook in select val hook and simplify it
f6302b0 
The hook is still defined; not using it could cause issues in IE<11.
Also, IE10 no longer throws when value not set but it still doesn't trim the
value. IE11 has all those issues fixed; support comments are updated.

Fixes jquerygh-1902
Closes jquerygh-1901
@mgol mgol closed this as completed in #1901 Dec 8, 2014
mgol added a commit that referenced this issue Dec 8, 2014
@mgol
Attributes: Simplify the option val hook; backport a test from master
aec41a5 
The hook is still defined; not using it could cause issues in IE<11.
Backport the test from the master branch.

Also, IE10 no longer throws when value not set but it still doesn't trim the
value. IE11 has all those issues fixed; support comments are updated.

(cherry-picked from f6302b0)

Fixes gh-1902
Closes gh-1901
@mgol mgol added this to the 3.0.0 milestone Oct 17, 2015
mgol added a commit that referenced this issue Nov 10, 2015
@mgol @markelog
Attributes: Use the option val hook in select val hook and simplify it
00e773f 
The hook is still defined; not using it could cause issues in IE<11.
Also, IE10 no longer throws when value not set but it still doesn't trim the
value. IE11 has all those issues fixed; support comments are updated.

Fixes gh-1902
Closes gh-1901
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@carols10cents carols10cents mentioned this issue Mar 8, 2016
Closed
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Attributes Bug
Milestone
1.12.0/2.2.0
Development

Successfully merging a pull request may close this issue.

Attributes: Use the option val hook in select val hook and simplify it mgol/jquery
2 participants
@dmethvin @mgol