Misc: Update isXML to recognize HTML-embedded elements#436
Closed
gibson042 wants to merge 2 commits intojquery:masterfrom
Closed
Misc: Update isXML to recognize HTML-embedded elements#436gibson042 wants to merge 2 commits intojquery:masterfrom
gibson042 wants to merge 2 commits intojquery:masterfrom
Conversation
mgol
approved these changes
Dec 3, 2018
timmywil
reviewed
Dec 4, 2018
| @@ -559,10 +560,13 @@ support = Sizzle.support = {}; | |||
| * @returns {Boolean} True iff elem is a non-HTML XML node | |||
Member
There was a problem hiding this comment.
Maybe we could go ahead and fix this typo, iff you want.
Member
Author
There was a problem hiding this comment.
What typo? Do you think we should replace "iff" with "if and only if"?
Member
There was a problem hiding this comment.
I didn't know that's what it meant. It's been a long time since I did proofs. I remember using "↔" but not "iff".
Member
There was a problem hiding this comment.
BTW, while I've used this notation repeatedly I'd guess it's not common knowledge among programmers without theoretical background. Expanding that could increase intelligibility of the comment to the general public.
markelog
approved these changes
Dec 5, 2018
timmywil
approved these changes
Dec 5, 2018
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jul 18, 2019
This commit also backports some jQuery.isXMLDoc tests from master so that this behavior doesn't regress. (partially cherry-picked from 79b74e0) Ref jquery/sizzle#378 Ref jquery/sizzle#436
3 tasks
mgol
added a commit
to jquery/jquery
that referenced
this pull request
Jul 29, 2019
This commit also backports some jQuery.isXMLDoc tests from master so that this behavior doesn't regress. (partially cherry-picked from 79b74e0) Closes gh-4438 Ref jquery/sizzle#378 Ref jquery/sizzle#436
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-378