Use configured letter-spacing values for custom font-size utilities#15099
Merged
adamwathan merged 4 commits intonextfrom Nov 22, 2024
Merged
Use configured letter-spacing values for custom font-size utilities#15099adamwathan merged 4 commits intonextfrom
adamwathan merged 4 commits intonextfrom
Conversation
philipp-spiess
approved these changes
Nov 22, 2024
Contributor
philipp-spiess
left a comment
philipp-spiess
left a comment
There was a problem hiding this comment.
LGTM! but let's revert the playground change
playgrounds/vite/src/index.css
Outdated
Comment on lines
+2
to
+8
|
|
||
| @theme { | ||
| --text-heading3xl: 2.25rem; | ||
| --text-heading3xl--line-height: 3rem; | ||
| --text-heading3xl--font-weight: 700; | ||
| --text-heading3xl--letter-spacing: -0.08375rem; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| @theme { | |
| --text-heading3xl: 2.25rem; | |
| --text-heading3xl--line-height: 3rem; | |
| --text-heading3xl--font-weight: 700; | |
| --text-heading3xl--letter-spacing: -0.08375rem; | |
| } |
Let's revert this change
adamwathan
added a commit
that referenced
this pull request
Nov 22, 2024
…15099) Fixes #15096. We were mistakenly reading from the `--tracking` sub-property but should be reading from `--letter-spacing`. To test this I copied the reproduction from the issue into our Vite playground and made sure the custom letter-spacing was being applied as expected: <img width="1443" alt="image" src="https://github.com/user-attachments/assets/bfc9ca23-bfc7-40d4-aec0-d3e715312eac"> --------- Co-authored-by: Adam Wathan <4323180+adamwathan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15096.
We were mistakenly reading from the
--trackingsub-property but should be reading from--letter-spacing.To test this I copied the reproduction from the issue into our Vite playground and made sure the custom letter-spacing was being applied as expected: