Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch support tests to use document.documentElement instead of document.body #2502

Closed
mgol opened this issue Jul 27, 2015 · 3 comments
Closed

Switch support tests to use document.documentElement instead of document.body #2502

mgol opened this issue Jul 27, 2015 · 3 comments
Assignees
@mgol
Labels
1.x-only Support wontfix

Comments

@mgol
Copy link
Member

mgol commented Jul 27, 2015

See #2133 (comment). I used document.body for support tests in 1.11 because of test failures but it seems no longer to be a problem, I'm able to run support tests in IE8 before document ready and they give correct result. We can synchronize these code paths.

Refs gh-2133.
@mgol mgol self-assigned this Jul 27, 2015
@mgol mgol added this to the 3.0.0 milestone Jul 27, 2015
@mgol mgol mentioned this issue Jul 27, 2015
Closed
mgol added a commit to mgol/jquery that referenced this issue Jul 28, 2015
@mgol
Core:CSS: Attach test nodes to documentElement, not body
9750b99 
Attaching test divs to document.documentElement instead of document.body
used to cause issues in jQuery 1.x; jQuery Compat doesn't execute any tests
on document ready, though so it could be aligned with master.

This makes jQuery Compat support tests work correctly even if jQuery is
included & used in head before body even exists - making it similar to
the master behavior.

Fixes jquerygh-2502
@mgol mgol mentioned this issue Jul 28, 2015
Merged
@mgol
Copy link
Member Author

mgol commented Jul 28, 2015

PR: #2504.

mgol added a commit to mgol/jquery that referenced this issue Jul 28, 2015
@mgol
Core:CSS: Attach test nodes to documentElement, not body
9de1f56 
Attaching test divs to document.documentElement instead of document.body
used to cause issues in jQuery 1.x; jQuery Compat doesn't execute any tests
on document ready, though so it could be aligned with master.

This makes jQuery Compat support tests work correctly even if jQuery is
included & used in head before body even exists - making it similar to
the master behavior.

Fixes jquerygh-2502
mgol added a commit to mgol/jquery that referenced this issue Jul 28, 2015
@mgol
Core:CSS: Attach test nodes to documentElement, not body
03e3565 
Attaching test divs to document.documentElement instead of document.body
used to cause issues in jQuery 1.x; jQuery Compat doesn't execute any tests
on document ready, though so it could be aligned with master.

This makes jQuery Compat support tests work correctly even if jQuery is
included & used in head before body even exists - making it similar to
the master behavior.

Fixes jquerygh-2502
mgol added a commit to mgol/jquery that referenced this issue Aug 16, 2015
@mgol
Core:CSS: Attach test nodes to documentElement, not body
9b04201 
Attaching test divs to document.documentElement instead of document.body
used to cause issues in jQuery 1.x; jQuery Compat doesn't execute any tests
on document ready, though so it could be aligned with master.

This makes jQuery Compat support tests work correctly even if jQuery is
included & used in head before body even exists - making it similar to
the master behavior.

Fixes jquerygh-2502
@mgol
Copy link
Member Author

mgol commented Sep 8, 2015

Landed at 9b04201.

@mgol mgol closed this as completed Sep 8, 2015
@mgol
Copy link
Member Author

mgol commented Nov 3, 2015

This has been problematic in IE<8 AFAIK so I'd rather not backport this to 1.12.

@mgol mgol removed this from the 3.0.0 milestone Nov 9, 2015
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
1.x-only Support wontfix
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgol