Skip to content

Commit 760521b

Browse files
committed
Merge pull request hojberg#4 from hojberg/color_pickers
added color picker
2 parents 2c26f97 + 57c0d80 commit 760521b

File tree

9 files changed

+950
-10
lines changed

9 files changed

+950
-10
lines changed

public/css/app.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ ul, ol, form { margin: 0; padding: 0; }
77
ul, ol { list-style-type: none; }
88
h1 { margin: 0; padding: 0; }
99
h2 { margin: 0; margin-bottom: 10px; padding: 0; font-weight: normal; font-size: 30px; color: rgba(0, 0, 0, 0.4); text-shadow: 0 1px 1px rgba(255, 255, 255, 0.5); }
10+
input { border: 1px solid #777; box-shadow: inset 0 1px 2px rgba(0, 0, 0, 0.2), 0 1px 1px 0 rgba(255, 255, 255, 0.3); border-radius: 4px; padding: 3px; -webkit-background-clip: padding-box; }
1011

1112
/* =LAYOUT
1213
====================================================== */
@@ -45,10 +46,9 @@ h2 { margin: 0; margin-bottom: 10px; padding: 0; font
4546
.configuration .size,
4647
.configuration .border_width { width: 25px; text-align: right; }
4748

48-
.configuration .color,
49-
.configuration .border_color { width: 60px; }
49+
.configuration .color { width: 60px; }
5050

51-
.configuration .unit { font-size: 14px; }
51+
.configuration .unit { font-size: 14px; color: rgba(0, 0, 0, 0.4); text-shadow: 0 1px 1px rgba(255, 255, 255, 0.5); }
5252

5353
/* result_code */
5454
.result_code { white-space: pre; padding: 10px; float: right; width: 380px; height: 370px; font-size: 12px; font-family: 'Courier new'; font-weight: bold; background: rgba(0, 0, 0, 0.15); border-radius: 4px; color: #fff; text-shadow: 0 1px 1px rgba(0, 0, 0, 0.3); border: 1px solid rgba(0, 0, 0, 0.2); box-shadow: 0 1px 1px 0 rgba(255, 255, 255, 0.3), inset 0 1px 5px rgba(0, 0, 0, 0.1); }

public/index.html

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ <h2>Arrow configuration</h2>
3838
</li>
3939
<li>
4040
<label>Color</label>
41-
<input class='color' />
41+
<input class='base_color color {hash:true,caps:false}' />
4242
</li>
4343
</ol>
4444
<ol class='section'>
@@ -49,7 +49,7 @@ <h2>Arrow configuration</h2>
4949
</li>
5050
<li>
5151
<label>Border color</label>
52-
<input class='border_color' />
52+
<input class='border_color color {hash:true,caps:false}' />
5353
</li>
5454
</ol>
5555
</div>
@@ -67,6 +67,8 @@ <h2>Arrow configuration</h2>
6767
</footer>
6868

6969
<script src='https://ajax.googleapis.com/ajax/libs/jquery/1.7.1/jquery.min.js'></script>
70+
<script type="text/javascript" src="js/vendor/jscolor/jscolor.js"></script>
71+
7072
<script src='js/lib/models/arrow.js'></script>
7173
<script src='js/lib/views/arrow_configuration_view.js'></script>
7274
<script src='js/lib/views/arrow_preview_view.js'></script>

public/js/lib/views/arrow_configuration_view.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ if (!('CSSArrowPlease' in window)) window.CSSArrowPlease = {};
3939

4040
container.find('.position').val( model.get('position') );
4141
container.find('.size').val( model.get('size') );
42-
container.find('.color').val( model.get('color') );
42+
container.find('.base_color').val( model.get('color') );
4343
container.find('.border_width').val( model.get('borderWidth') );
4444
container.find('.border_color').val( model.get('borderColor') );
4545
},
@@ -54,7 +54,7 @@ if (!('CSSArrowPlease' in window)) window.CSSArrowPlease = {};
5454
container = this.container,
5555
selectors = [ '.position',
5656
'.size',
57-
'.color',
57+
'.base_color',
5858
'.border_width',
5959
'.border_color'
6060
];
@@ -76,6 +76,9 @@ if (!('CSSArrowPlease' in window)) window.CSSArrowPlease = {};
7676
else if (target.hasClass('border_color')) {
7777
attr = 'borderColor';
7878
}
79+
else if (target.hasClass('base_color')) {
80+
attr = 'color';
81+
}
7982
else {
8083
attr = target.attr('class');
8184
}

public/js/spec/views/arrow_configuration_view_spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ describe("CSSArrowPlease.ArrowConfigurationView", function () {
99
<option value='left'>left</option>\
1010
</select>\
1111
<input class='size'>\
12-
<input class='color'>\
12+
<input class='base_color'>\
1313
<input class='border_width'>\
1414
<input class='border_color'>\
1515
</div>";
@@ -36,7 +36,7 @@ describe("CSSArrowPlease.ArrowConfigurationView", function () {
3636

3737
expect( $container.find('.position').val() ).toBe(arrow.get('position'));
3838
expect( parseInt($container.find('.size').val(), 10) ).toBe(arrow.get('size'));
39-
expect( $container.find('.color').val() ).toBe(arrow.get('color'));
39+
expect( $container.find('.base_color').val() ).toBe(arrow.get('color'));
4040
expect( parseInt($container.find('.border_width').val(), 10) ).toBe(arrow.get('borderWidth'));
4141
expect( $container.find('.border_color').val() ).toBe(arrow.get('borderColor'));
4242

@@ -55,7 +55,7 @@ describe("CSSArrowPlease.ArrowConfigurationView", function () {
5555
});
5656

5757
it('syncs when color is changed', function () {
58-
$container.find('.color').val('#0f0').trigger('change');
58+
$container.find('.base_color').val('#0f0').trigger('change');
5959
expect( arrow.get('color') ).toEqual('#0f0');
6060
});
6161

public/js/vendor/jscolor/arrow.gif

66 Bytes
Loading

public/js/vendor/jscolor/cross.gif

83 Bytes
Loading

public/js/vendor/jscolor/hs.png

2.62 KB
Loading

public/js/vendor/jscolor/hv.png

2.8 KB
Loading

0 commit comments

Comments
 (0)