From 736bb0786aad102ee1bcab05fe81a64e130649ce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Khrise=20Franchesca=20Zegarra=20Mu=C3=B1oz?= <129009072+Khrisefzm@users.noreply.github.com> Date: Thu, 21 Dec 2023 18:48:31 +0000 Subject: [PATCH 1/2] change last part of the test.js to acept everithing that ends with #thirditem --- exercises/05-Specificity/styles.css | 1 + exercises/05-Specificity/tests.js | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/exercises/05-Specificity/styles.css b/exercises/05-Specificity/styles.css index 1255fbbc..7aa5babf 100644 --- a/exercises/05-Specificity/styles.css +++ b/exercises/05-Specificity/styles.css @@ -6,3 +6,4 @@ li + #thirditem { background: yellow; } /**** DO NOT EDIT ANYTHING ABOVE THIS LINE ****/ + diff --git a/exercises/05-Specificity/tests.js b/exercises/05-Specificity/tests.js index 2323ce24..8d8f9fc3 100644 --- a/exercises/05-Specificity/tests.js +++ b/exercises/05-Specificity/tests.js @@ -43,7 +43,8 @@ describe("All the styles should be applied", function () { let cssArray = document.styleSheets[0].cssRules; let orangeHoverSelector = ""; for (let i = 0; i < cssArray.length; i++) { - if (cssArray[i].selectorText === "#thirditem" && cssArray[i].style._importants.background === "important" || cssArray[i].style._importants["background-color"] === "important") { + // here is the problem, the only selector acepted is #thirditem so if you read li + #thirditem or li #thirditem or li + #thirditem is not acepted + if (cssArray[i].selectorText.endsWith("#thirditem") && cssArray[i].style._importants.background === "important" || cssArray[i].style._importants["background-color"] === "important") { orangeHoverSelector = cssArray[i].style.background || cssArray[i].style["background-color"]; } } From 6b196081256b4d3f451dc87c1ee49e6f95ecbc53 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Khrise=20Franchesca=20Zegarra=20Mu=C3=B1oz?= <129009072+Khrisefzm@users.noreply.github.com> Date: Thu, 21 Dec 2023 18:51:57 +0000 Subject: [PATCH 2/2] delete comment --- exercises/05-Specificity/styles.css | 1 - exercises/05-Specificity/tests.js | 1 - 2 files changed, 2 deletions(-) diff --git a/exercises/05-Specificity/styles.css b/exercises/05-Specificity/styles.css index 7aa5babf..1255fbbc 100644 --- a/exercises/05-Specificity/styles.css +++ b/exercises/05-Specificity/styles.css @@ -6,4 +6,3 @@ li + #thirditem { background: yellow; } /**** DO NOT EDIT ANYTHING ABOVE THIS LINE ****/ - diff --git a/exercises/05-Specificity/tests.js b/exercises/05-Specificity/tests.js index 8d8f9fc3..3ea381ec 100644 --- a/exercises/05-Specificity/tests.js +++ b/exercises/05-Specificity/tests.js @@ -43,7 +43,6 @@ describe("All the styles should be applied", function () { let cssArray = document.styleSheets[0].cssRules; let orangeHoverSelector = ""; for (let i = 0; i < cssArray.length; i++) { - // here is the problem, the only selector acepted is #thirditem so if you read li + #thirditem or li #thirditem or li + #thirditem is not acepted if (cssArray[i].selectorText.endsWith("#thirditem") && cssArray[i].style._importants.background === "important" || cssArray[i].style._importants["background-color"] === "important") { orangeHoverSelector = cssArray[i].style.background || cssArray[i].style["background-color"]; }