From 5b8fdb2002ba4a1accbef803be71e316d491cbb8 Mon Sep 17 00:00:00 2001 From: ErnestoXG Date: Thu, 23 Mar 2023 14:32:14 +0000 Subject: [PATCH 1/2] instructions now using default value, solution as well --- exercises/02.1-Background/README.es.md | 2 +- exercises/02.1-Background/README.md | 2 +- exercises/02.1-Background/solution.hide.css | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/exercises/02.1-Background/README.es.md b/exercises/02.1-Background/README.es.md index 45a32554..1d975de7 100644 --- a/exercises/02.1-Background/README.es.md +++ b/exercises/02.1-Background/README.es.md @@ -14,7 +14,7 @@ Si es una imagen, puedes especificar si quieres que la imagen se repita horizont 4. Construye y previsualiza el ejercicio nuevamente. -5. Cambia el `background-repeat` a `inherit` para que se repita sobre el eje x y el eje y. +5. Cambia el `background-repeat` a `repeat` para que se repita sobre el eje x y el eje y. 6. Construye y previsualiza el ejercicio nuevamente. diff --git a/exercises/02.1-Background/README.md b/exercises/02.1-Background/README.md index 3ae8139b..fe82957e 100644 --- a/exercises/02.1-Background/README.md +++ b/exercises/02.1-Background/README.md @@ -19,7 +19,7 @@ If it is an image, you can specify if you want the image to be repeated horizont 4. Build and Preview the exercise again. -5. Change the background-repeat to 'inherit' to make it repeat over the x axis and y axis. +5. Change the background-repeat to 'repeat' to make it repeat over the x axis and y axis. 6. Build and Preview the exercise again. diff --git a/exercises/02.1-Background/solution.hide.css b/exercises/02.1-Background/solution.hide.css index 8c72a684..a2c6b305 100644 --- a/exercises/02.1-Background/solution.hide.css +++ b/exercises/02.1-Background/solution.hide.css @@ -1,5 +1,5 @@ body { background-image: url(https://4geeksacademy.github.io/exercise-assets/img/bg/small-mosaic.jpg); background-size: contain; - background-repeat: inherit; -} \ No newline at end of file + background-repeat: repeat; +} From a8e25b6b70d993978dc9cf248815ad448046673c Mon Sep 17 00:00:00 2001 From: ErnestoXG Date: Thu, 23 Mar 2023 14:32:36 +0000 Subject: [PATCH 2/2] test now checking for default value repeat --- exercises/02.1-Background/tests.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/exercises/02.1-Background/tests.js b/exercises/02.1-Background/tests.js index b223105f..bc1a1daf 100644 --- a/exercises/02.1-Background/tests.js +++ b/exercises/02.1-Background/tests.js @@ -28,13 +28,13 @@ describe("All the styles should be applied", ()=>{ expect(styles["background-size"]).toBe("contain"); }); - test("the background-repeat should be 'inherit' without quotes", ()=>{ + test("the background-repeat should be 'repeat' without quotes", ()=>{ document.querySelector( "head" ).innerHTML = ``; let styles = window.getComputedStyle(body); - expect(styles["background-repeat"]).toBe("inherit"); + expect(styles["background-repeat"]).toBe("repeat"); }); test("You should not change the existing head tag elements", ()=>{