[CLI-282] TypeHandler should throw ParseException for an unsupported

class.

Author: deepy

src/changes/changes.xml

@@ -38,6 +38,9 @@
       <action type="add" dev="ggregory" due-to="Jason Dillon" issue="CLI-276">
         Adjust access-modifier of checkRequiredOptions() to protected.
       </action>
+      <action type="add" dev="ggregory" due-to="Alex Nordlund" issue="CLI-282">
+        TypeHandler should throw ParseException for an unsupported class.
+      </action>
     </release>
 
     <release version="1.4" date="2017-03-09" description="New features and bug fixes">

src/main/java/org/apache/commons/cli/TypeHandler.java

@@ -100,7 +100,7 @@ else if (PatternOptionBuilder.URL_VALUE == clazz)
         }
         else
         {
-            return null;
+            throw new ParseException("Unable to handle the class: " + clazz);
         }
     }
 

src/test/java/org/apache/commons/cli/TypeHandlerTest.java

@@ -148,6 +148,13 @@ public void testCreateValueURL_malformed()
         TypeHandler.createValue("malformed-url", PatternOptionBuilder.URL_VALUE);
     }
 
+    @Test(expected = ParseException.class)
+    public void testCreateValueInteger_failure()
+            throws Exception
+    {
+        TypeHandler.createValue("just-a-string", Integer.class);
+    }
+
     public static class Instantiable
     {
     }