From 97da8b71f90aa82d42ba61ebf2f05cf56f12cd24 Mon Sep 17 00:00:00 2001 From: Acinho <53146324+Acinho@users.noreply.github.com> Date: Tue, 14 Apr 2020 01:12:01 +0200 Subject: [PATCH 1/3] Fixed check for canceling last animation frame for invisible check (#289) Co-authored-by: Aleksandar Adamovic --- src/ResizeSensor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ResizeSensor.js b/src/ResizeSensor.js index 12985d0..2bae953 100755 --- a/src/ResizeSensor.js +++ b/src/ResizeSensor.js @@ -305,7 +305,7 @@ this.detach = function(ev) { // clean up the unfinished animation frame to prevent a potential endless requestAnimationFrame of reset - if (!lastAnimationFrameForInvisibleCheck) { + if (lastAnimationFrameForInvisibleCheck) { cancelAnimationFrame(lastAnimationFrameForInvisibleCheck); lastAnimationFrameForInvisibleCheck = 0; } From ee21dfe74f096e8733183296ad34af89a18992ba Mon Sep 17 00:00:00 2001 From: Achara Date: Mon, 13 Apr 2020 19:14:10 -0400 Subject: [PATCH 2/3] fix invoking element.resizeSensor.resetSensor when it is undefined to cause js error (#291) Co-authored-by: akelley --- src/ResizeSensor.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/ResizeSensor.js b/src/ResizeSensor.js index 2bae953..9a25503 100755 --- a/src/ResizeSensor.js +++ b/src/ResizeSensor.js @@ -313,13 +313,19 @@ }; this.reset = function() { - element.resizeSensor.resetSensor(); + //To prevent invoking element.resizeSensor.resetSensor if it's undefined + if (element.resizeSensor.resetSensor) { + element.resizeSensor.resetSensor(); + } }; }; ResizeSensor.reset = function(element) { forEachElement(element, function(elem){ - elem.resizeSensor.resetSensor(); + //To prevent invoking element.resizeSensor.resetSensor if it's undefined + if (element.resizeSensor.resetSensor) { + elem.resizeSensor.resetSensor(); + } }); }; From 4eae4654f4683923153d8dd8f5c0d1bc2067b2a8 Mon Sep 17 00:00:00 2001 From: Maksym Kobieliev Date: Fri, 3 Jul 2020 18:51:03 +0300 Subject: [PATCH 3/3] Add a Size interface to the typings (#293) Co-authored-by: Maksym Kobieliev --- css-element-queries.d.ts | 2 +- src/ResizeSensor.d.ts | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/css-element-queries.d.ts b/css-element-queries.d.ts index 97ee144..3fe0706 100644 --- a/css-element-queries.d.ts +++ b/css-element-queries.d.ts @@ -1,2 +1,2 @@ -export { ResizeSensor, ResizeSensorCallback } from "./src/ResizeSensor"; +export { ResizeSensor, ResizeSensorCallback, Size } from "./src/ResizeSensor"; export { ElementQueries } from './src/ElementQueries'; \ No newline at end of file diff --git a/src/ResizeSensor.d.ts b/src/ResizeSensor.d.ts index ad6c412..3fba8c6 100644 --- a/src/ResizeSensor.d.ts +++ b/src/ResizeSensor.d.ts @@ -1,4 +1,9 @@ -export declare type ResizeSensorCallback = (size: { width: number; height: number; }) => void; +export declare interface Size { + width: number; + height: number; +} + +export declare type ResizeSensorCallback = (size: Size) => void; export declare class ResizeSensor { /**