Skip to content

Commit 4db8589

Browse files
committed
Fixing the nearbyController default language
Also fixes the settingsFragment to select different primary and secondary description labels.
1 parent 1d479f0 commit 4db8589

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,8 @@ public String getPlacesAsGPX(LatLng currentLocation) throws Exception {
147147
*/
148148
public List<Place> getPlaces(List<Place> placeList) throws Exception {
149149
String secondaryLanguages = defaultKvStore.getString(Prefs.SECONDARY_LANGUAGES, "");
150-
return nearbyPlaces.getPlaces(placeList, Locale.getDefault().getLanguage(), secondaryLanguages);
150+
String primaryLanguage = defaultKvStore.getString(Prefs.DESCRIPTION_LANGUAGE, "");
151+
return nearbyPlaces.getPlaces(placeList, primaryLanguage, secondaryLanguages);
151152
}
152153

153154
public static LatLng calculateNorthEast(double latitude, double longitude, double distance) {

app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.kt

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -309,14 +309,23 @@ class SettingsFragment : PreferenceFragmentCompat() {
309309

310310
private fun prepareSecondaryLanguagesDialog() {
311311
val languageCode = getCurrentLanguageCode("descriptionSecondaryLanguagesPref")
312+
val defaultCode = getCurrentLanguageCode("descriptionDefaultLanguagePref")
312313
val selectedLanguages = hashMapOf<Int, String>()
314+
315+
var deflocale = Locale.getDefault()
316+
317+
318+
if (defaultCode != null){
319+
deflocale = createLocale(defaultCode)
320+
}
321+
313322
languageCode?.let {
314-
selectedLanguages[0] = Locale.getDefault().language
323+
selectedLanguages[0] = deflocale.language
315324
}
316325

317326
val savedLanguages = arrayListOf<Language>()
318327
languageCode?.split(",\\s*".toRegex())?.forEach { code ->
319-
if (code != Locale.getDefault().language) {
328+
if (code != deflocale.language) {
320329
val locale = Locale(code)
321330
savedLanguages.add(Language(locale.displayLanguage, code))
322331
}

0 commit comments

Comments
 (0)