Fixed missing semicolon separator #135

FlorianRappl · FlorianRappl · commit 6905fa5ea6d1 · 2023-06-14T14:57:59.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@ Released on tbd.
 - Updated to use AngleSharp 1.0
 - Fixed issue when updating shorthands with invalid values (#129)
 - Fixed issue with appended EOF character in `CssText` (#123)
+- Fixed missing semicolon in `@page` rule (#135)
 
 # 0.17.0
 
diff --git a/src/AngleSharp.Css.Tests/Rules/CssPageRule.cs b/src/AngleSharp.Css.Tests/Rules/CssPageRule.cs
@@ -0,0 +1,32 @@
+namespace AngleSharp.Css.Tests.Rules
+{
+    using AngleSharp.Css.Dom;
+    using NUnit.Framework;
+    using System.Linq;
+
+    [TestFixture]
+    public class CssPageRuleTests
+    {
+        [Test]
+        public void SemiColonsShouldNotMissInPageRule_Issue135()
+        {
+            var html = "<html><body><style>@page { margin-top: 25mm; margin-right: 25mm }</style></body></html>";
+            var document = html.ToHtmlDocument(Configuration.Default.WithCss());
+            var styleSheet = document.StyleSheets.OfType<ICssStyleSheet>().First();
+            var css = styleSheet.ToCss();
+
+            Assert.AreEqual("@page { margin-top: 25mm; margin-right: 25mm }", css);
+        }
+
+        [Test]
+        public void PageRuleShouldRecombineShorthandDeclaration_Issue135()
+        {
+            var html = "<html><body><style>@page { margin: 25mm }</style></body></html>";
+            var document = html.ToHtmlDocument(Configuration.Default.WithCss());
+            var styleSheet = document.StyleSheets.OfType<ICssStyleSheet>().First();
+            var css = styleSheet.ToCss();
+
+            Assert.AreEqual("@page { margin: 25mm }", css);
+        }
+    }
+}
diff --git a/src/AngleSharp.Css/Dom/Internal/Rules/CssPageRule.cs b/src/AngleSharp.Css/Dom/Internal/Rules/CssPageRule.cs
@@ -60,7 +60,7 @@ protected override void ReplaceWith(ICssRule rule)
 
         public override void ToCss(TextWriter writer, IStyleFormatter formatter)
         {
-            var rules = formatter.BlockRules(_style);
+            var rules = _style.ToCssBlock(formatter);
             writer.Write(formatter.Rule(RuleNames.Page, SelectorText, rules));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ protected override void ReplaceWith(ICssRule rule)`
`60`	`60`
`61`	`61`	`public override void ToCss(TextWriter writer, IStyleFormatter formatter)`
`62`	`62`	`{`
`63`		`- var rules = formatter.BlockRules(_style);`
	`63`	`+ var rules = _style.ToCssBlock(formatter);`
`64`	`64`	`writer.Write(formatter.Rule(RuleNames.Page, SelectorText, rules));`
`65`	`65`	`}`
`66`	`66`