Skip to content

Commit 7d4703a

Browse files
committed
fixed tests
1 parent d02eef8 commit 7d4703a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/AngleSharp.Css.Tests/Values/UnitConversion.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public void LengthToPixelsPercentThrowsOnInvalidRenderDimensions()
5151
public void LengthToPixelsEmThrowsOnInvalidRenderDimensions()
5252
{
5353
var l = new Length(50, Length.Unit.Em);
54-
var renderDevice = new DefaultRenderDevice();
54+
var renderDevice = new DefaultRenderDevice { FontSize = 0 };
5555
Assert.Throws<ArgumentException>(() => l.ToPixel(renderDevice));
5656
Assert.Throws<ArgumentException>(() => l.ToPixel(null));
5757
}
@@ -100,7 +100,7 @@ public void LengthToPixelsCorrectVh()
100100
public void LengthToPixelsCorrectVw()
101101
{
102102
var l = new Length(20, Length.Unit.Vw);
103-
var renderDevice = new DefaultRenderDevice {ViewPortHeight = 1000};
103+
var renderDevice = new DefaultRenderDevice {ViewPortWidth = 1000};
104104
Assert.AreEqual(200, l.ToPixel(renderDevice));
105105
}
106106

src/AngleSharp.Css/Values/Primitives/Length.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -379,15 +379,15 @@ public Double To(Unit unit, IRenderDimensions renderDimensions, Boolean isWidth
379379

380380
private void CheckForValidRenderDimensions(IRenderDimensions renderDimensions, bool isWidth)
381381
{
382-
if (renderDimensions == null || (isWidth ? renderDimensions.RenderWidth : renderDimensions.RenderHeight) > 0)
382+
if (renderDimensions == null || (isWidth ? renderDimensions.RenderWidth : renderDimensions.RenderHeight) <= 0)
383383
{
384384
throw new ArgumentException("A non null render device with a font size is required to calculate em or rem units.");
385385
}
386386
}
387387

388388
private void CheckForValidRenderDimensionsForFont(IRenderDimensions renderDimensions)
389389
{
390-
if (renderDimensions == null || renderDimensions.FontSize > 0)
390+
if (renderDimensions == null || renderDimensions.FontSize <= 0)
391391
{
392392
throw new ArgumentException("A non null render device with a font size is required to calculate em or rem units.");
393393
}

0 commit comments

Comments
 (0)