Fix view that lists already uploaded files.

Transform PictureListView to a generic ListView
Fix url to use as_view()

Author: sigurdga

fileupload/urls.py

@@ -1,6 +1,10 @@
 # encoding: utf-8
 from django.conf.urls import patterns, url
-from fileupload.views import BasicVersionCreateView, BasicPlusVersionCreateView, PictureCreateView, AngularVersionCreateView, jQueryVersionCreateView, PictureDeleteView
+from fileupload.views import (
+        BasicVersionCreateView, BasicPlusVersionCreateView,
+        jQueryVersionCreateView, AngularVersionCreateView,
+        PictureCreateView, PictureDeleteView, PictureListView,
+        )
 
 urlpatterns = patterns('',
     (r'^basic/$', BasicVersionCreateView.as_view(), {}, 'upload-basic'),
@@ -9,7 +13,7 @@
     (r'^angular/$', AngularVersionCreateView.as_view(), {}, 'upload-angular'),
     (r'^jquery-ui/$', jQueryVersionCreateView.as_view(), {}, 'upload-jquery'),
     (r'^delete/(?P<pk>\d+)$', PictureDeleteView.as_view(), {}, 'upload-delete'),
-    url(r'^view/$', 'fileupload.views.PictureListView', name='upload-view'),
+    url(r'^view/$', PictureListView.as_view(), name='upload-view'),
 )
 
 

fileupload/views.py

@@ -1,5 +1,5 @@
 # encoding: utf-8
-from django.views.generic import CreateView, DeleteView, View
+from django.views.generic import CreateView, DeleteView, ListView
 from .models import Picture
 from .response import JSONResponse, response_mimetype
 from .serialize import serialize
@@ -44,12 +44,12 @@ def delete(self, request, *args, **kwargs):
         return response
 
 
-class PictureListView(View):
-    def get(self, request, *args, **kwargs):
-        files = []
-        for obj in Picture.objects.all():
-            files.append(serialize(obj))
+class PictureListView(ListView):
+    model = Picture
+
+    def render_to_response(self, context, **response_kwargs):
+        files = [ serialize(p) for p in self.get_queryset() ]
         data = {'files': files}
-        response = JSONResponse(data, mimetype=response_mimetype(request))
+        response = JSONResponse(data, mimetype=response_mimetype(self.request))
         response['Content-Disposition'] = 'inline; filename=files.json'
         return response