Allows the user to ignore properties and selectors when matching

Author: zmoazeni

CHANGELOG.md

@@ -1,3 +1,7 @@
+## (Unreleased) ##
+
+* Allows the user to specify ignored properties and selectors
+
 ## 0.2.1 - 3/28/2013 ##
 
 * Changes coloring to the selectors and declarations

lib/csscss/cli.rb

@@ -1,11 +1,13 @@
 module Csscss
   class CLI
     def initialize(argv)
-      @argv    = argv
-      @verbose = false
-      @color   = true
-      @minimum = 3
-      @compass = false
+      @argv               = argv
+      @verbose            = false
+      @color              = true
+      @minimum            = 3
+      @compass            = false
+      @ignored_properties = []
+      @ignored_selectors  = []
     end
 
     def run
@@ -40,7 +42,9 @@ def execute
           open(filename) {|f| f.read }
         end
 
-        RedundancyAnalyzer.new(contents).redundancies(@minimum)
+        RedundancyAnalyzer.new(contents).redundancies(minimum:           @minimum,
+                                                     ignored_properties: @ignored_properties,
+                                                     ignored_selectors:  @ignored_selectors)
       end
 
       combined_redundancies = all_redundancies.inject({}) do |combined, redundancies|
@@ -83,6 +87,14 @@ def parse(argv)
           @minimum = n
         end
 
+        opts.on("--ignore-properties property1,property2,...", Array, "Ignore these properties when finding matches") do |ignored_properties|
+          @ignored_properties = ignored_properties
+        end
+
+        opts.on('--ignore-selectors "selector1","selector2",...', Array, "Ignore these selectors when finding matches") do |ignored_selectors|
+          @ignored_selectors = ignored_selectors
+        end
+
         opts.on("-V", "--version", "Show version") do |v|
           puts opts.ver
           exit

lib/csscss/redundancy_analyzer.rb

@@ -5,13 +5,20 @@ def initialize(raw_css)
       @raw_css = raw_css
     end
 
-    def redundancies(minimum = nil)
+    def redundancies(opts = {})
+      minimum            = opts[:minimum]
+      ignored_properties = opts[:ignored_properties] || []
+      ignored_selectors  = opts[:ignored_selectors] || []
+
       rule_sets = Parser::Css.parse(@raw_css)
       matches = {}
       parents = {}
       rule_sets.each do |rule_set|
+        next if ignored_selectors.include?(rule_set.selectors.selectors)
+        sel = rule_set.selectors
+
         rule_set.declarations.each do |dec|
-          sel = rule_set.selectors
+          next if ignored_properties.include?(dec.property)
 
           if parser = shorthand_parser(dec.property)
             if new_decs = parser.parse(dec.property, dec.value)

test/csscss/redundancy_analyzer_test.rb

@@ -22,7 +22,7 @@ module Csscss
         [sel(".bar"), sel("h1, h2")] , [dec("outline", "none"), dec("position", "relative")]
       ]
 
-      RedundancyAnalyzer.new(css).redundancies(2).must_equal({
+      RedundancyAnalyzer.new(css).redundancies(minimum:2).must_equal({
         [sel(".bar"), sel("h1, h2")] => [dec("outline", "none"), dec("position", "relative")]
       })
     end
@@ -88,7 +88,7 @@ module Csscss
         }
       $
 
-      redundancies = RedundancyAnalyzer.new(css).redundancies(3)
+      redundancies = RedundancyAnalyzer.new(css).redundancies(minimum:3)
       redundancies[[sel(".bar"), sel(".bar2"), sel(".baz")]].size.must_equal(5)
     end
 
@@ -230,7 +230,7 @@ module Csscss
         [sel(".bar"), sel(".baz"), sel(".foo")] => [dec("border-style", "solid"), dec("border-width", "4px")]
       })
 
-      RedundancyAnalyzer.new(css).redundancies(2).must_equal({
+      RedundancyAnalyzer.new(css).redundancies(minimum:2).must_equal({
         [sel(".bar"), sel(".baz"), sel(".foo")] => [dec("border-style", "solid"), dec("border-width", "4px")]
       })
     end
@@ -248,6 +248,24 @@ module Csscss
       })
     end
 
+    it "ignores specific properties" do
+      css = %$
+        h1, h2 { display: none; position: relative; outline:none}
+        .foo { DISPLAY: none; width: 1px }
+        .bar { position: relative; width: 1px; outline: none }
+        .baz { display: none }
+      $
+
+      RedundancyAnalyzer.new(css).redundancies(ignored_properties:%w(display outline)).must_equal({
+        [sel(".bar"), sel("h1, h2")] => [dec("position", "relative")],
+        [sel(".bar"), sel(".foo")] => [dec("width", "1px")],
+      })
+
+      RedundancyAnalyzer.new(css).redundancies(ignored_properties:%w(display outline), ignored_selectors:%w(.foo)).must_equal({
+        [sel(".bar"), sel("h1, h2")] => [dec("position", "relative")]
+      })
+    end
+
     # TODO: someday
     # it "reports duplication within the same selector" do
     #   css = %$