Fixes commons-app#4300 Limited connection mode banner occupies too much space (commons-app#4375)

* done

* fixed

* minor changes made

changed tv, Tv to text_view, TextView, improved comment for toggleDescriptionListener

Author: vinayak0505

app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java

@@ -89,6 +89,7 @@ public class ContributionsFragment
     @BindView(R.id.card_view_nearby) public NearbyNotificationCardView nearbyNotificationCardView;
     @BindView(R.id.campaigns_view) CampaignView campaignView;
     @BindView(R.id.limited_connection_enabled_layout) LinearLayout limitedConnectionEnabledLayout;
+    @BindView(R.id.limited_connection_description_text_view) TextView limitedConnectionDescriptionTextView;
 
     @Inject ContributionsPresenter contributionsPresenter;
 
@@ -158,6 +159,7 @@ public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container,
             && sessionManager.getCurrentAccount() != null) {
             setUploadCount();
         }
+        limitedConnectionEnabledLayout.setOnClickListener(toggleDescriptionListener);
         setHasOptionsMenu(true);
         return view;
     }
@@ -617,5 +619,21 @@ public void backButtonClicked() {
     public MediaDetailPagerFragment getMediaDetailPagerFragment() {
         return mediaDetailPagerFragment;
     }
+
+  // click listener to toggle description that means uses can press the limited connection
+  // banner and description will hide. Tap again to show description.
+  private View.OnClickListener toggleDescriptionListener = new View.OnClickListener() {
+
+      @Override
+      public void onClick(View view) {
+          View view2 = limitedConnectionDescriptionTextView;
+          if (view2.getVisibility() == View.GONE) {
+              view2.setVisibility(View.VISIBLE);
+          } else {
+              view2.setVisibility(View.GONE);
+          }
+      }
+  };
+
 }
 

app/src/main/res/layout/fragment_contributions.xml

@@ -20,25 +20,27 @@
 
   <LinearLayout
     android:id="@+id/limited_connection_enabled_layout"
+    android:animateLayoutChanges="true"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:layout_margin="@dimen/miniscule_margin"
     android:padding="@dimen/standard_gap"
     android:orientation="vertical"
+    android:clickable="true"
+    android:focusable="true"
     android:background="@color/wikimedia_green">
-    <ImageView
-      android:layout_width="wrap_content"
-      android:layout_height="wrap_content"
-      android:layout_marginBottom="@dimen/small_gap"
-      app:srcCompat="@drawable/ic_baseline_cloud_off_72"/>
     <TextView
       android:layout_width="wrap_content"
       android:layout_height="wrap_content"
+      android:drawablePadding="5dp"
       android:textColor="@android:color/white"
       android:layout_marginBottom="@dimen/tiny_gap"
       android:textSize="@dimen/subheading_text_size"
-      android:text="@string/limited_connection_is_on"/>
+      android:text="@string/limited_connection_is_on"
+      app:drawableTint="@color/white"
+      app:drawableStartCompat="@drawable/ic_baseline_cloud_off_24"/>
     <TextView
+      android:id="@+id/limited_connection_description_text_view"
       android:layout_width="wrap_content"
       android:layout_height="wrap_content"
       android:textColor="@android:color/white"