Fixes commons-app#4297 - UI Issue: After changing the system theme from settings (commons-app#4332)

* fix UI issue after theme change

* removed unnecessary changes

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>

Author: Pratham2305

app/src/main/java/fr/free/nrw/commons/bookmarks/BookmarkFragment.java

@@ -12,6 +12,7 @@
 
 import com.google.android.material.tabs.TabLayout;
 
+import fr.free.nrw.commons.contributions.MainActivity;
 import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
 import fr.free.nrw.commons.explore.ParentViewPager;
 import fr.free.nrw.commons.kvstore.JsonKvStore;
@@ -78,6 +79,10 @@ public View onCreateView(@NonNull final LayoutInflater inflater,
                                         applicationKvStore.getBoolean("login_skipped"));
     viewPager.setAdapter(adapter);
     tabLayout.setupWithViewPager(viewPager);
+
+    ((MainActivity)getActivity()).showTabs();
+    ((BaseActivity) getActivity()).getSupportActionBar().setDisplayHomeAsUpEnabled(false);
+
     setupTabLayout();
     return view;
   }

app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java

@@ -148,6 +148,9 @@ public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container,
         if(shouldShowMediaDetailsFragment){
             showMediaDetailPagerFragment();
         }else{
+            if (mediaDetailPagerFragment != null) {
+                removeFragment(mediaDetailPagerFragment);
+            }
             showContributionsListFragment();
         }
 

app/src/main/java/fr/free/nrw/commons/explore/ExploreFragment.java

@@ -15,6 +15,7 @@
 import com.google.android.material.tabs.TabLayout;
 import fr.free.nrw.commons.R;
 import fr.free.nrw.commons.ViewPagerAdapter;
+import fr.free.nrw.commons.contributions.MainActivity;
 import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
 import fr.free.nrw.commons.theme.BaseActivity;
 import fr.free.nrw.commons.utils.ActivityUtils;
@@ -87,6 +88,9 @@ public void setTabs() {
         fragmentList.add(mobileRootFragment);
         titleList.add(getString(R.string.explore_tab_title_mobile).toUpperCase());
 
+        ((MainActivity)getActivity()).showTabs();
+        ((BaseActivity) getActivity()).getSupportActionBar().setDisplayHomeAsUpEnabled(false);
+
         viewPagerAdapter.setTabData(fragmentList, titleList);
         viewPagerAdapter.notifyDataSetChanged();
     }

app/src/main/res/layout/fragment_bookmarks.xml

@@ -34,6 +34,7 @@
       android:id="@+id/viewPagerBookmarks"
       android:layout_width="match_parent"
       android:layout_height="match_parent"
-      android:layout_below="@id/toolbar_layout" />
+      android:layout_below="@id/toolbar_layout"
+      android:background="?attr/mainBackground" />
 
 </RelativeLayout>

app/src/main/res/layout/fragment_explore.xml

@@ -34,5 +34,6 @@
         android:id="@+id/viewPager"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
-        android:layout_below="@id/toolbar_layout" />
+        android:layout_below="@id/toolbar_layout"
+        android:background="?attr/mainBackground"/>
 </RelativeLayout>

app/src/main/res/layout/fragment_search_paginated.xml

@@ -3,7 +3,8 @@
   android:layout_width="match_parent"
   android:layout_height="match_parent"
   android:orientation="vertical"
-  android:paddingTop="@dimen/tiny_gap">
+  android:paddingTop="@dimen/tiny_gap"
+  android:background="?attr/mainBackground">
 
   <TextView
     android:id="@+id/contentNotFound"

app/src/main/res/layout/toolbar.xml

@@ -6,4 +6,5 @@
     android:layout_height="?attr/actionBarSize"
     android:fitsSystemWindows="true"
     app:titleTextColor="?attr/toolbar_text_color"
+    android:background="?attr/mainBackground"
     />