Skip to content

Commit 36d436b

Browse files
apsdehalarschmitz
apsdehal
authored and
arschmitz
committed
Dialog: html lint free tests and demos
1 parent babe945 commit 36d436b

6 files changed

Lines changed: 11 additions & 9 deletions

File tree

‎demos/pages-dialog/dialog-with-select.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ <h1>Sample Dialogs</h1>
3232

3333
<div role="main" class="ui-content">
3434

35-
<form action="">
35+
<form action="#">
3636
<div class="ui-field-contain">
3737
<label for="select-choice-1" class="select">Choose shipping method:</label>
3838
<select name="select-choice-1" id="select-choice-1" data-native-menu="false">

‎tests/integration/dialog-extension/backcompat-tests.html‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ <h2>Corners Initially Off Test</h2>
7676
Close
7777
<span class="ui-page-dialog-close-button-icon ui-icon-delete ui-icon"></span>
7878
</a>
79-
<h2 class="ui-title" role="heading" aria-level="1">Corners Initially On</h2>
79+
<h2 class="ui-title" data-role="heading" aria-level="1">Corners Initially On</h2>
8080
</div>
8181
<div class="ui-content">
8282
<p>Test</p>
@@ -91,7 +91,7 @@ <h2 class="ui-title" role="heading" aria-level="1">Corners Initially On</h2>
9191
Close
9292
<span class="ui-page-dialog-close-button-icon ui-icon-delete ui-icon"></span>
9393
</a>
94-
<h2 class="ui-title" role="heading" aria-level="1">Corners Initially Off Test</h2>
94+
<h2 class="ui-title" data-role="heading" aria-level="1">Corners Initially Off Test</h2>
9595
</div>
9696
<div class="ui-content">
9797
<p>Test</p>
@@ -106,7 +106,7 @@ <h2 class="ui-title" role="heading" aria-level="1">Corners Initially Off Test</h
106106
Close
107107
<span class="ui-page-dialog-close-button-icon ui-icon-delete ui-icon"></span>
108108
</a>
109-
<h2 class="ui-title" role="heading" aria-level="1">Corners Initially On</h2>
109+
<h2 class="ui-title" data-role="heading" aria-level="1">Corners Initially On</h2>
110110
</div>
111111
<div class="ui-content">
112112
<p>Test</p>
@@ -121,7 +121,7 @@ <h2 class="ui-title" role="heading" aria-level="1">Corners Initially On</h2>
121121
Close
122122
<span class="ui-page-dialog-close-button-icon ui-icon-delete ui-icon"></span>
123123
</a>
124-
<h2 class="ui-title" role="heading" aria-level="1">Corners Initially Off Test</h2>
124+
<h2 class="ui-title" data-role="heading" aria-level="1">Corners Initially Off Test</h2>
125125
</div>
126126
<div class="ui-content">
127127
<p>Test</p>

‎tests/integration/dialog-extension/dialog-no-hash.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4+
<title>Dialog No Hash</title>
45
</head>
56
<body>
67
<div data-nstest-role="dialog" id="dialog-no-hash">

‎tests/integration/dialog-extension/index.html‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ <h1>Dialog</h1>
5353
<h1>Dialog</h1>
5454
</div>
5555
<div class="ui-content">
56-
<a href="#" id="internal-link">foo</a>
56+
<a href="#" id="internal-link-2">foo</a>
5757
</div>
5858
<div data-nstest-role="toolbar" data-nstest-type="footer">
5959
footer
@@ -65,7 +65,7 @@ <h1>Dialog</h1>
6565
<h1>Dialog</h1>
6666
</div>
6767
<div class="ui-content">
68-
<a href="#" id="internal-link">foo</a>
68+
<a href="#" id="internal-link-3">foo</a>
6969
</div>
7070
<div data-nstest-role="toolbar" data-nstest-type="footer">
7171
footer
@@ -115,7 +115,7 @@ <h1> data-nstest-theme & data-nstest-overlay-theme set </h1>
115115
Close
116116
<span class="ui-page-dialog-close-button-icon ui-icon-delete ui-icon"></span>
117117
</a>
118-
<h1 class="ui-title" role="heading" aria-level="1">Dialog</h1>
118+
<h1 class="ui-title" data-role="heading" aria-level="1">Dialog</h1>
119119
</div>
120120
<div class="ui-content">
121121
<p>Contents</p>

‎tests/integration/dialog/dialog-no-hash.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4+
<title>Dialog No Hash</title>
45
</head>
56
<body>
67
<div data-nstest-role="dialog" id="dialog-no-hash">

‎tests/integration/dialog/index.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ <h1>Dialog</h1>
5151
<h1>Dialog</h1>
5252
</div>
5353
<div data-nstest-role="content" >
54-
<a href="#" id="internal-link">foo</a>
54+
<a href="#" id="internal-link-1">foo</a>
5555
</div>
5656
<div data-nstest-role="toolbar" data-nstest-type="footer">
5757
footer

0 commit comments

Comments
 (0)