Skip to content

Commit 808b9dd

Browse files
committed
cleanup
1 parent 50570f6 commit 808b9dd

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ ExtractTextPlugin.prototype.apply = function(compiler) {
320320
}
321321
if(meta.content) {
322322
var ident = module.identifier();
323-
extractCompilation.addResultToChunk(ident, meta.content, newModule, extractedChunk);
323+
extractCompilation.addResultToChunk(ident, meta.content, module, extractedChunk);
324324
// remove generated result from chunk
325325
if(toRemoveModules[ident]) {
326326
toRemoveModules[ident].chunks.push(chunk)

loader.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,17 +128,18 @@ module.exports.pitch = function (request) {
128128
if (module.hot) {
129129
module.hot.accept();
130130
if (module.hot.data) {
131-
require(${loaderUtils.stringifyRequest(this, path.resolve('./hotModuleReplacement.js'))})("${publicPath}", "%%extracted-file%%");
131+
require(${loaderUtils.stringifyRequest(this, path.join(__dirname, "hotModuleReplacement.js"))})("${publicPath}", "%%extracted-file%%");
132132
}
133133
}`;
134134
}
135135
} catch (e) {
136136
return callback(e);
137137
}
138138
if (resultSource) {
139-
return callback(null, resultSource);
139+
callback(null, resultSource);
140+
} else {
141+
callback();
140142
}
141-
callback();
142143
}.bind(this));
143144
}
144145
};

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
},
3131
"dependencies": {
3232
"async": "^2.1.2",
33-
"jsesc": "^2.5.1",
3433
"loader-utils": "^1.0.2",
3534
"schema-utils": "^0.3.0",
3635
"style-loader": "^0.18.2",

yarn.lock

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2064,10 +2064,6 @@ jsbn@~0.1.0:
20642064
version "0.1.1"
20652065
resolved "https://registry.yarnpkg.com/jsbn/-/jsbn-0.1.1.tgz#a5e654c2e5a2deb5f201d96cefbca80c0ef2f513"
20662066

2067-
jsesc@^2.5.1:
2068-
version "2.5.1"
2069-
resolved "https://registry.yarnpkg.com/jsesc/-/jsesc-2.5.1.tgz#e421a2a8e20d6b0819df28908f782526b96dd1fe"
2070-
20712067
jsesc@~0.5.0:
20722068
version "0.5.0"
20732069
resolved "https://registry.yarnpkg.com/jsesc/-/jsesc-0.5.0.tgz#e7dee66e35d6fc16f710fe91d5cf69f70f08911d"
@@ -4121,9 +4117,9 @@ webpack-sources@^1.0.1:
41214117
source-list-map "^2.0.0"
41224118
source-map "~0.5.3"
41234119

4124-
webpack@2.6.0:
4125-
version "2.6.0"
4126-
resolved "https://registry.yarnpkg.com/webpack/-/webpack-2.6.0.tgz#7e650a92816abff5db5f43316b0b8b19b13d76c1"
4120+
webpack@~2.6.0:
4121+
version "2.6.1"
4122+
resolved "https://registry.yarnpkg.com/webpack/-/webpack-2.6.1.tgz#2e0457f0abb1ac5df3ab106c69c672f236785f07"
41274123
dependencies:
41284124
acorn "^5.0.0"
41294125
acorn-dynamic-import "^2.0.0"

0 commit comments

Comments
 (0)