Merge pull request apache#266 from mykolaf/delimcheck

Validate input to setDelimiter(String) for empty string

Author: garydgregory

src/main/java/org/apache/commons/csv/CSVFormat.java

@@ -346,6 +346,9 @@ public Builder setDelimiter(final String delimiter) {
             if (containsLineBreak(delimiter)) {
                 throw new IllegalArgumentException("The delimiter cannot be a line break");
             }
+            if (delimiter.isEmpty()) {
+                throw new IllegalArgumentException("The delimiter cannot be empty");
+            }
             this.delimiter = delimiter;
             return this;
         }

src/test/java/org/apache/commons/csv/CSVFormatTest.java

@@ -1569,4 +1569,9 @@ public void testWithSystemRecordSeparator() {
         final CSVFormat formatWithRecordSeparator = CSVFormat.DEFAULT.withSystemRecordSeparator();
         assertEquals(System.lineSeparator(), formatWithRecordSeparator.getRecordSeparator());
     }
+
+    @Test
+    public void testDelimiterEmptyStringThrowsException1() {
+        assertThrows(IllegalArgumentException.class, () -> CSVFormat.DEFAULT.builder().setDelimiter("").build());
+    }
 }