bad logic, should use || rather than &&, but instanceof covers the null case anyway

mebigfatguy · mebigfatguy · commit 9acd5cd4d32f · 2011-11-10T03:37:47.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/sandbox/csv/trunk@1200112 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/commons/csv/writer/CSVConfig.java b/src/main/java/org/apache/commons/csv/writer/CSVConfig.java
@@ -283,7 +283,7 @@ public void setFieldHeader(boolean fieldHeader) {
      * @see java.lang.Object#equals(java.lang.Object)
      */
     public boolean equals(Object obj) {
-        if (obj == null && !(obj instanceof CSVConfig)) {
+        if (!(obj instanceof CSVConfig)) {
             return false;
         }
         return super.equals(obj);

Original file line number	Diff line number	Diff line change
`@@ -283,7 +283,7 @@ public void setFieldHeader(boolean fieldHeader) {`
`283`	`283`	`* @see java.lang.Object#equals(java.lang.Object)`
`284`	`284`	`*/`
`285`	`285`	`public boolean equals(Object obj) {`
`286`		`- if (obj == null && !(obj instanceof CSVConfig)) {`
	`286`	`+ if (!(obj instanceof CSVConfig)) {`
`287`	`287`	`return false;`
`288`	`288`	`}`
`289`	`289`	`return super.equals(obj);`