Skip to content

Commit 00c6859

Browse files
jkleinnzakas
authored andcommitted
Adding some tests for the viewport start and end events, and fixing two other existing tests that were broken
1 parent 7e3e523 commit 00c6859

File tree

1 file changed

+25
-3
lines changed

1 file changed

+25
-3
lines changed

tests/css/Parser.js

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -981,7 +981,7 @@
981981

982982
name: "Property Values",
983983

984-
testDimensionValue: function(){
984+
testDimensionValuePx: function(){
985985
var parser = new Parser();
986986
var result = parser.parsePropertyValue("1px");
987987

@@ -1399,7 +1399,7 @@
13991399

14001400
testWebKitKeyFrames: function(){
14011401
var parser = new Parser({strict:true}),
1402-
called = true;
1402+
called = false;
14031403

14041404
parser.addListener("startkeyframes", function(event) {
14051405
Assert.areEqual("webkit", event.prefix);
@@ -1478,6 +1478,28 @@
14781478
Assert.isTrue(true); //just don't want an error
14791479
},
14801480

1481+
testViewportEventFires: function(){
1482+
var parser = new Parser({ strict:true}),
1483+
calledStart = false,
1484+
calledEnd = false;
1485+
1486+
parser.addListener("startviewport", function(event) {
1487+
Assert.areEqual(1, event.line, "Line should be 1");
1488+
Assert.areEqual(1, event.col, "Column should be 1");
1489+
calledStart = true;
1490+
});
1491+
1492+
parser.addListener("endviewport", function(event) {
1493+
Assert.areEqual(1, event.line, "Line should be 1");
1494+
Assert.areEqual(1, event.col, "Column should be 1");
1495+
calledEnd = true;
1496+
});
1497+
1498+
var result = parser.parse("@viewport { width: 397px; }");
1499+
Assert.isTrue(calledStart); //just don't want an error
1500+
Assert.isTrue(calledEnd); //just don't want an error
1501+
},
1502+
14811503
testClassesWithEscapes: function(){
14821504
var parser = new Parser({strict:true});
14831505
var result = parser.parseSelector("#\\31 a2b3c");
@@ -1642,7 +1664,7 @@
16421664
"Test parsing invalid celector": function(){
16431665
var error;
16441666
var parser = new Parser();
1645-
parser.addListener("error", function(e){error = e});
1667+
parser.addListener("error", function(e){error = e;});
16461668
parser.parse("c++{}");
16471669

16481670
Assert.areEqual("error", error.type);

0 commit comments

Comments
 (0)