Skip to content

Commit 69e350f

Browse files
committed
Merge pull request #105 from sparanoid/viewport-unit-update
Update viewport units
2 parents 283c0f1 + c81ebdb commit 69e350f

File tree

4 files changed

+23
-7
lines changed

4 files changed

+23
-7
lines changed

src/css/PropertyValuePart.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ function PropertyValuePart(text, line, col){
4646
case "ch":
4747
case "vh":
4848
case "vw":
49-
case "vm":
49+
case "vmax":
50+
case "vmin":
5051
this.type = "length";
5152
break;
5253

src/css/TokenStream.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ TokenStream.prototype = mix(new TokenStreamBase(), {
642642
ident = this.readName(reader.read());
643643
value += ident;
644644

645-
if (/^em$|^ex$|^px$|^gd$|^rem$|^vw$|^vh$|^vm$|^ch$|^cm$|^mm$|^in$|^pt$|^pc$/i.test(ident)){
645+
if (/^em$|^ex$|^px$|^gd$|^rem$|^vw$|^vh$|^vmax$|^vmin$|^ch$|^cm$|^mm$|^in$|^pt$|^pc$/i.test(ident)){
646646
tt = Tokens.LENGTH;
647647
} else if (/^deg|^rad$|^grad$/i.test(ident)){
648648
tt = Tokens.ANGLE;

tests/css/Parser.js

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,15 +1025,26 @@
10251025
Assert.areEqual("vw", result.parts[0].units);
10261026
},
10271027

1028+
testViewportRelativeMaxValue: function(){
1029+
var parser = new Parser();
1030+
var result = parser.parsePropertyValue("50vmax");
1031+
1032+
Assert.isInstanceOf(parserlib.css.PropertyValue, result);
1033+
Assert.areEqual(1, result.parts.length);
1034+
Assert.areEqual("length", result.parts[0].type);
1035+
Assert.areEqual(50, result.parts[0].value);
1036+
Assert.areEqual("vmax", result.parts[0].units);
1037+
},
1038+
10281039
testViewportRelativeMinValue: function(){
10291040
var parser = new Parser();
1030-
var result = parser.parsePropertyValue("50vm");
1041+
var result = parser.parsePropertyValue("50vmin");
10311042

10321043
Assert.isInstanceOf(parserlib.css.PropertyValue, result);
10331044
Assert.areEqual(1, result.parts.length);
10341045
Assert.areEqual("length", result.parts[0].type);
10351046
Assert.areEqual(50, result.parts[0].value);
1036-
Assert.areEqual("vm", result.parts[0].units);
1047+
Assert.areEqual("vmin", result.parts[0].units);
10371048
},
10381049

10391050
testPercentageValue: function(){

tests/css/TokenStream.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -313,9 +313,13 @@
313313
"50.0REM" : [CSSTokens.LENGTH],
314314
".5rEm" : [CSSTokens.LENGTH],
315315

316-
"5vm" : [CSSTokens.LENGTH],
317-
"50.0VM" : [CSSTokens.LENGTH],
318-
".5vM" : [CSSTokens.LENGTH],
316+
"5vmax" : [CSSTokens.LENGTH],
317+
"50.0VMAX" : [CSSTokens.LENGTH],
318+
".5vMax" : [CSSTokens.LENGTH],
319+
320+
"5vmin" : [CSSTokens.LENGTH],
321+
"50.0VMIN" : [CSSTokens.LENGTH],
322+
".5vMin" : [CSSTokens.LENGTH],
319323

320324
"5ch" : [CSSTokens.LENGTH],
321325
"50.0CH" : [CSSTokens.LENGTH],

0 commit comments

Comments
 (0)