Merge pull request #100 from mattiacci/ident-underscore

nzakas · nzakas · commit 83c43b293706 · 2014-01-25T10:51:43.000-08:00
Allow underscores in identifiers
diff --git a/src/css/PropertyValuePart.js b/src/css/PropertyValuePart.js
@@ -149,7 +149,7 @@ function PropertyValuePart(text, line, col){
     } else if (/^[\,\/]$/.test(text)){
         this.type   = "operator";
         this.value  = text;
-    } else if (/^[a-z\-\u0080-\uFFFF][a-z0-9\-\u0080-\uFFFF]*$/i.test(text)){
+    } else if (/^[a-z\-_\u0080-\uFFFF][a-z0-9\-_\u0080-\uFFFF]*$/i.test(text)){
         this.type   = "identifier";
         this.value  = text;
     }
diff --git a/tests/css/Validation.js b/tests/css/Validation.js
@@ -69,7 +69,8 @@
             "foo",
             "foo, bar",
             "none, none",
-            "none, foo"
+            "none, foo",
+            "has_underscore"
         ],
 
         invalid: {

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ function PropertyValuePart(text, line, col){`
`149`	`149`	`} else if (/^[\,\/]$/.test(text)){`
`150`	`150`	`this.type = "operator";`
`151`	`151`	`this.value = text;`
`152`		`- } else if (/^[a-z\-\u0080-\uFFFF][a-z0-9\-\u0080-\uFFFF]*$/i.test(text)){`
	`152`	`+ } else if (/^[a-z\-_\u0080-\uFFFF][a-z0-9\-_\u0080-\uFFFF]*$/i.test(text)){`
`153`	`153`	`this.type = "identifier";`
`154`	`154`	`this.value = text;`
`155`	`155`	`}`