Skip to content

Commit a988f2e

Browse files
committed
Fix problems on project ideas page
1 parent 39dec14 commit a988f2e

File tree

2 files changed

+54
-26
lines changed

2 files changed

+54
-26
lines changed

themes/vocabulary_theme/templates/project-ideas.html

+27-23
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ <h1>Open Source Internships: Project Ideas</h1>
88
<p class="description">This is the project idea list for the <span class="has-color-forest-green">current round of open source internships at Creative Commons.</span></p>
99
{% set ideas = site.query('/internships/project-ideas-collection').include_undiscoverable(true) %}
1010
<div class="filter-labels" id="project-list">
11-
<button type="button" class="button tag filter-btn" data-filter="all">
11+
<button type="button" class="button tag btn-dark filter-btn" data-filter="all">
1212
All Projects
1313
</button>
1414
<button type="button" class="button tag filter-btn" data-filter="difficulty-easy">
@@ -36,46 +36,50 @@ <h1>Open Source Internships: Project Ideas</h1>
3636
<div class="project-ideas columns is-multiline">
3737
{% for idea in ideas %}
3838
<div class="column is-one-quarter filter filter-label {{ idea.filter_value }}">
39-
<article class="card entry-post horizontal">
40-
<div class="card-content with-button">
41-
<h5 class="card-title"><a href="#{{ idea._slug }}">{{ idea.title }}</a></h5>
42-
</div>
43-
</article>
39+
<a href="#{{ idea._slug }}">
40+
<article class="card entry-post horizontal">
41+
<div class="card-content">
42+
<h5 class="card-title">{{ idea.title }}</h5>
43+
</div>
44+
</article>
45+
</a>
4446
</div>
4547
{% endfor %}
4648
<div class="column is-one-quarter">
47-
<article class="card entry-post horizontal">
48-
<div class="card-content with-button">
49-
<h5 class="card-title"><a href="#original-ideas">Original Ideas</a></h5>
50-
</div>
51-
</article>
49+
<a href="#original-ideas">
50+
<article class="card entry-post horizontal">
51+
<div class="card-content">
52+
<h5 class="card-title">Original Ideas</h5>
53+
</div>
54+
</article>
55+
</a>
5256
</div>
5357
</div>
5458
</div>
5559
</div>
56-
<div class="body container content">
60+
<div class="body container">
5761
{% for idea in ideas %}
5862
<div class="project-idea">
5963
<h2><a class="has-color-dark-slate-gray" name="{{ idea._slug }}">{{ idea.title }}</a></h2>
6064
<div class="columns">
6165
<div class="column is-one-quarter">
62-
<h5>Difficulty</h5>
63-
<p>{{ idea.difficulty }}</p>
64-
<h5>Skills recommended</h5>
65-
<p>{{ idea.skills_recommended }}</p>
66-
<h5>Mentors</h5>
67-
<p>{{ idea.mentors }}</p>
66+
<h5 class="b-header padding-bottom-small">Difficulty</h5>
67+
<p class="padding-bottom-big">{{ idea.difficulty }}</p>
68+
<h5 class="b-header padding-bottom-small">Skills recommended</h5>
69+
<p class="padding-bottom-big">{{ idea.skills_recommended }}</p>
70+
<h5 class="b-header padding-bottom-small">Mentors</h5>
71+
<p class="padding-bottom-big">{{ idea.mentors }}</p>
6872
</div>
6973
<div class="column is-three-quarters">
70-
<h5>The Problem</h5>
74+
<h3 class="padding-bottom-big">The Problem</h3>
7175
<p>{{ idea.problem }}</p>
72-
<h5>Expected Outcome</h5>
76+
<h3 class="padding-bottom-big padding-top-large">Expected Outcome</h3>
7377
<p>{{ idea.expected_outcome }}</p>
74-
<h5>Internship Tasks</h5>
78+
<h3 class="padding-bottom-big padding-top-large">Internship Tasks</h3>
7579
<p>{{ idea.internship_tasks }}</p>
76-
<h5>Application Tips</h5>
80+
<h3 class="padding-bottom-big padding-top-large">Application Tips</h3>
7781
<p>{{ idea.application_tips }}</p>
78-
<h5>Resources</h5>
82+
<h3 class="padding-bottom-big padding-top-large">Resources</h3>
7983
<p>{{ idea.resources }}</p>
8084
</div>
8185
</div>

webpack/sass/main.scss

+27-3
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,12 @@ code {
526526
@extend .margin-right-normal;
527527
@extend .margin-bottom-normal;
528528
}
529+
530+
.btn-dark, :hover {
531+
@extend .has-background-gold;
532+
@extend .has-color-dark-slate-gray;
533+
border: none;
534+
}
529535
}
530536

531537
.project-ideas {
@@ -539,6 +545,13 @@ code {
539545
.card {
540546
height: 100%;
541547
}
548+
549+
:hover {
550+
.entry-post {
551+
border: 0.1875rem solid $color-dark-gray;
552+
}
553+
text-decoration: none;
554+
}
542555
}
543556
}
544557
}
@@ -547,12 +560,23 @@ code {
547560
@extend .padding-top-larger;
548561
@extend .padding-bottom-xxl;
549562
@extend .padding-horizontal-big;
563+
@extend .body-big;
550564

551565
.project-idea {
552566
@extend .padding-bottom-xl;
553-
567+
554568
.column {
555-
@extend .padding-top-normal;
569+
@extend .padding-top-large;
570+
571+
li:before {
572+
content: "\ea02";
573+
font-family: "Vocabulary Icons";
574+
display: inline-block;
575+
font-size: 0.375rem;
576+
color: $color-gray;
577+
578+
@extend .padding-right-small;
579+
}
556580
}
557581

558582
&::after {
@@ -577,7 +601,7 @@ code {
577601
@extend .caption;
578602

579603
text-decoration: none;
580-
604+
581605
.icon {
582606
@extend .padding-right-small;
583607
}

0 commit comments

Comments
 (0)