Skip to content

Commit 25b52e4

Browse files
committed
Better parameter name
Better instance variable name
1 parent ab4fed2 commit 25b52e4

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

src/main/java/org/apache/commons/cli/Option.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ public static Builder builder(final String option) {
417417
private List<String> values = new ArrayList<>();
418418

419419
/** The character that is the value separator. */
420-
private char valuesep;
420+
private char valueSeparator;
421421

422422
/**
423423
* Private constructor used by the nested Builder class.
@@ -435,7 +435,7 @@ private Option(final Builder builder) {
435435
this.required = builder.required;
436436
this.since = builder.since;
437437
this.type = builder.type;
438-
this.valuesep = builder.valueSeparator;
438+
this.valueSeparator = builder.valueSeparator;
439439
this.converter = builder.converter;
440440
}
441441

@@ -727,7 +727,7 @@ public String[] getValues() {
727727
* @return the value separator character.
728728
*/
729729
public char getValueSeparator() {
730-
return valuesep;
730+
return valueSeparator;
731731
}
732732

733733
/**
@@ -805,7 +805,7 @@ public boolean hasOptionalArg() {
805805
* @since 1.1
806806
*/
807807
public boolean hasValueSeparator() {
808-
return valuesep > 0;
808+
return valueSeparator > 0;
809809
}
810810

811811
/**
@@ -969,10 +969,10 @@ public void setType(final Object type) {
969969
/**
970970
* Sets the value separator. For example if the argument value was a Java property, the value separator would be '='.
971971
*
972-
* @param sep The value separator.
972+
* @param valueSeparator The value separator.
973973
*/
974-
public void setValueSeparator(final char sep) {
975-
this.valuesep = sep;
974+
public void setValueSeparator(final char valueSeparator) {
975+
this.valueSeparator = valueSeparator;
976976
}
977977

978978
String toDeprecatedString() {

0 commit comments

Comments
 (0)