Parser no longer removes the required options from the Options instance (CLI-156)

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/cli/branches/cli-1.x@661332 13f79535-47bb-0310-9956-ffa450edef68

Author: ebourg

src/java/org/apache/commons/cli/Parser.java

@@ -16,6 +16,7 @@
  */
 package org.apache.commons.cli;
 
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Enumeration;
 import java.util.Iterator;
@@ -43,7 +44,7 @@ public abstract class Parser implements CommandLineParser {
 
     protected void setOptions(final Options options) {
         this.options = options;
-        this.requiredOptions = options.getRequiredOptions();
+        this.requiredOptions = new ArrayList(options.getRequiredOptions());
     }
 
     protected Options getOptions() {

src/test/org/apache/commons/cli/ParseRequiredTest.java

@@ -140,4 +140,26 @@ public void testMissingRequiredOptions()
         }
     }
 
+    public void testReuseOptionsTwice() throws Exception
+    {
+        Options opts = new Options();
+		opts.addOption(OptionBuilder.isRequired().create('v'));
+
+		GnuParser parser = new GnuParser();
+
+        // first parsing
+        parser.parse(opts, new String[] { "-v" });
+
+        try
+        {
+            // second parsing, with the same Options instance and an invalid command line
+            parser.parse(opts, new String[0]);
+            fail("MissingOptionException not thrown");
+        }
+        catch (MissingOptionException e)
+        {
+            // expected
+        }
+    }
+
 }