improved PR

Author: sokra

example/webpack.config.js

@@ -1,4 +1,3 @@
-var fs = require('fs');
 var webpack = require("webpack");
 var ExtractTextPlugin = require("../");
 module.exports = {
@@ -9,7 +8,7 @@ module.exports = {
 	output: {
 		filename: "[name].js?[hash]-[chunkhash]",
 		chunkFilename: "[name].js?[hash]-[chunkhash]",
-		path: fs.realpathSync(__dirname) + "/assets",
+		path: __dirname + "/assets",
 		publicPath: "/assets/"
 	},
 	module: {

index.js

@@ -10,6 +10,8 @@ var Chunk = require("webpack/lib/Chunk");
 var OrderUndefinedError = require("./OrderUndefinedError");
 var loaderUtils = require("loader-utils");
 
+var NS = fs.realpathSync(__dirname);
+
 var nextId = 0;
 
 function ExtractTextPluginCompilation() {
@@ -206,16 +208,16 @@ ExtractTextPlugin.prototype.apply = function(compiler) {
 	compiler.plugin("this-compilation", function(compilation) {
 		var extractCompilation = new ExtractTextPluginCompilation();
 		compilation.plugin("normal-module-loader", function(loaderContext, module) {
-			loaderContext[fs.realpathSync(__dirname)] = function(content, opt) {
+			loaderContext[NS] = function(content, opt) {
 				if(options.disable)
 					return false;
 				if(!Array.isArray(content) && content != null)
 					throw new Error("Exported value was not extracted as an array: " + JSON.stringify(content));
-				module.meta[fs.realpathSync(__dirname)] = {
+				module.meta[NS] = {
 					content: content,
 					options: opt || {}
 				};
-				return options.allChunks || module.meta[fs.realpathSync(__dirname) + "/extract"]; // eslint-disable-line no-path-concat
+				return options.allChunks || module.meta[NS + "/extract"]; // eslint-disable-line no-path-concat
 			};
 		});
 		var filename = this.filename;
@@ -242,17 +244,17 @@ ExtractTextPlugin.prototype.apply = function(compiler) {
 				var extractedChunk = extractedChunks[chunks.indexOf(chunk)];
 				var shouldExtract = !!(options.allChunks || chunk.isInitial());
 				async.forEach(chunk.modules.slice(), function(module, callback) {
-					var meta = module.meta && module.meta[fs.realpathSync(__dirname)];
+					var meta = module.meta && module.meta[NS];
 					if(meta && (!meta.options.id || meta.options.id === id)) {
 						var wasExtracted = Array.isArray(meta.content);
 						if(shouldExtract !== wasExtracted) {
-							module.meta[fs.realpathSync(__dirname) + "/extract"] = shouldExtract; // eslint-disable-line no-path-concat
+							module.meta[NS + "/extract"] = shouldExtract; // eslint-disable-line no-path-concat
 							compilation.rebuildModule(module, function(err) {
 								if(err) {
 									compilation.errors.push(err);
 									return callback();
 								}
-								meta = module.meta[fs.realpathSync(__dirname)];
+								meta = module.meta[NS];
 								if(!Array.isArray(meta.content)) {
 									err = new Error(module.identifier() + " doesn't export content");
 									compilation.errors.push(err);

loader.js

@@ -2,29 +2,34 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
+var fs = require("fs");
 var loaderUtils = require("loader-utils");
 var NodeTemplatePlugin = require("webpack/lib/node/NodeTemplatePlugin");
 var NodeTargetPlugin = require("webpack/lib/node/NodeTargetPlugin");
 var LibraryTemplatePlugin = require("webpack/lib/LibraryTemplatePlugin");
 var SingleEntryPlugin = require("webpack/lib/SingleEntryPlugin");
 var LimitChunkCountPlugin = require("webpack/lib/optimize/LimitChunkCountPlugin");
+
+var NS = fs.realpathSync(__dirname);
+
 module.exports = function(source) {
 	if(this.cacheable) this.cacheable();
 	return source;
 };
+
 module.exports.pitch = function(request) {
 	if(this.cacheable) this.cacheable();
 	var query = loaderUtils.parseQuery(this.query);
 	this.addDependency(this.resourcePath);
 	// We already in child compiler, return empty bundle
-	if(this[fs.realpathSync(__dirname)] === undefined) {
+	if(this[NS] === undefined) {
 		throw new Error(
 			'"extract-text-webpack-plugin" loader is used without the corresponding plugin, ' +
 			'refer to https://github.com/webpack/extract-text-webpack-plugin for the usage example'
 		);
-	} else if(this[fs.realpathSync(__dirname)] === false) {
+	} else if(this[NS] === false) {
 		return "";
-	} else if(this[fs.realpathSync(__dirname)](null, query)) {
+	} else if(this[NS](null, query)) {
 		if(query.omit) {
 			this.loaderIndex += +query.omit + 1;
 			request = request.split("!").slice(+query.omit).join("!");
@@ -48,19 +53,19 @@ module.exports.pitch = function(request) {
 		childCompiler.apply(new NodeTargetPlugin());
 		childCompiler.apply(new SingleEntryPlugin(this.context, "!!" + request));
 		childCompiler.apply(new LimitChunkCountPlugin({ maxChunks: 1 }));
-		var subCache = "subcache " + fs.realpathSync(__dirname) + " " + request; // eslint-disable-line no-path-concat
+		var subCache = "subcache " + NS + " " + request; // eslint-disable-line no-path-concat
 		childCompiler.plugin("compilation", function(compilation) {
 			if(compilation.cache) {
 				if(!compilation.cache[subCache])
 					compilation.cache[subCache] = {};
 				compilation.cache = compilation.cache[subCache];
 			}
 		});
-		// We set loaderContext[fs.realpathSync(__dirname)] = false to indicate we already in
+		// We set loaderContext[NS] = false to indicate we already in
 		// a child compiler so we don't spawn another child compilers from there.
 		childCompiler.plugin("this-compilation", function(compilation) {
 			compilation.plugin("normal-module-loader", function(loaderContext) {
-				loaderContext[fs.realpathSync(__dirname)] = false;
+				loaderContext[NS] = false;
 			});
 		});
 		var source;
@@ -103,7 +108,7 @@ module.exports.pitch = function(request) {
 							item[0] = module.identifier();
 					});
 				});
-				this[fs.realpathSync(__dirname)](text, query);
+				this[NS](text, query);
 				if(text.locals && typeof resultSource !== "undefined") {
 					resultSource += "\nmodule.exports = " + JSON.stringify(text.locals) + ";";
 				}

test/TestCases.test.js

@@ -5,13 +5,13 @@ var webpack = require("webpack");
 var should = require("should");
 var ExtractTextPlugin = require("../");
 
-var cases = process.env.CASES ? process.env.CASES.split(",") : fs.readdirSync(path.join(fs.realpathSync(__dirname), "cases"));
+var cases = process.env.CASES ? process.env.CASES.split(",") : fs.readdirSync(path.join(__dirname, "cases"));
 
 describe("TestCases", function() {
 	cases.forEach(function(testCase) {
 		it(testCase, function(done) {
-			var testDirectory = path.join(fs.realpathSync(__dirname), "cases", testCase);
-			var outputDirectory = path.join(fs.realpathSync(__dirname), "js", testCase);
+			var testDirectory = path.join(__dirname, "cases", testCase);
+			var outputDirectory = path.join(__dirname, "js", testCase);
 			var options = { entry: { test: "./index.js" } };
 			var configFile = path.join(testDirectory, "webpack.config.js");
 			if(fs.existsSync(configFile))