refactor(scrollView): do not update if not rendered

Author: adamdbradley

js/views/scrollView.js

@@ -1245,6 +1245,11 @@ ionic.views.Scroll = ionic.views.View.inherit({
   setDimensions: function(clientWidth, clientHeight, contentWidth, contentHeight) {
     var self = this;
 
+    if (!clientWidth && !clientHeight && !contentWidth && !contentHeight) {
+      // this scrollview isn't rendered, don't bother
+      return;
+    }
+
     // Only update values which are defined
     if (clientWidth === +clientWidth) {
       self.__clientWidth = clientWidth;

test/unit/angular/controller/scrollController.unit.js

@@ -95,14 +95,6 @@ describe('$ionicScroll Controller', function() {
     expect(ctrl.scrollView.run).toHaveBeenCalled();
   });
 
-  it('should resize the scrollview on window resize', function() {
-    setup();
-    timeout.flush();
-    spyOn(ctrl.scrollView, 'resize');
-    ionic.trigger('resize', { target: window });
-    expect(ctrl.scrollView.resize).toHaveBeenCalled();
-  });
-
 
   it('should unbind window event listener on scope destroy', inject(function($window) {
     spyOn(ionic, 'on');
@@ -130,16 +122,6 @@ describe('$ionicScroll Controller', function() {
     expect(scope.$onScroll.mostRecentCall.args[0].scrollTop).toBe(3);
   });
 
-  it('.resize() should resize after timeout', inject(function($timeout) {
-    setup();
-    $timeout.flush();
-    spyOn(ctrl.scrollView, 'resize');
-    ctrl.resize();
-    expect(ctrl.scrollView.resize).not.toHaveBeenCalled();
-    $timeout.flush();
-    expect(ctrl.scrollView.resize).toHaveBeenCalled();
-  }));
-
   it('.getScrollView', function() {
     setup();
     expect(ctrl.getScrollView()).toBe(ctrl.scrollView);