Skip to content

Commit dfa5167

Browse files
authored
fix: project plan for issue commons-app#3463
Change it account for us working on multiple issues
1 parent e64082a commit dfa5167

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

report.md

+10-9
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,19 @@ This project is android app where you users can upload their pictures to the wik
1616

1717
## Project Plan
1818

19-
The issues is that this project uses the Junit assert in their kotlin test but they want to upgrade
20-
it to use appropriate AssertThat which comes from the (hamcrest dependency). The project has many
21-
test cases roughly 1500 to be exact which means that to make this work many test cases has to be
19+
### Issue [#3463](https://github.com/commons-app/apps-android-commons/issues/3463)
20+
21+
This issue addresses that the project uses the Junit assert in their kotlin test but they want to upgrade
22+
it to use appropriate AssertThat which comes from the (hamcrest dependency). The project has a lot of
23+
test cases, roughly 1500 to be exact, which means that to make this work many test cases has to be
2224
rewritten.
2325

24-
The way we plan to do this is that we divide the work so that each person takes a separate folder of
25-
closely related test and convert the test cases to use assertThat instead. The result of the test
26-
cases should not change a they should still succeed after the change this is the only requirement and
27-
that the new test uses assertThat.
26+
The way we plan to do this is by using `grep` and pattern matching to change the common assert patterns. This will minimize the amout of manual work, though some will still need to be done for less common patterns.
27+
28+
The result of the test cases should not change a they should still succeed after the change, and this is the only
29+
requirement in addition to changing the tests to assertThat.
2830

29-
the team should use the following [link](https://hamcrest.org/JavaHamcrest/tutorial) to use get more
30-
familiar with assertThat
31+
Guide to assertThat [link](https://hamcrest.org/JavaHamcrest/tutorial)
3132

3233
## Onboarding experience
3334

0 commit comments

Comments
 (0)