From b8c0412a85c67727684c55846c8e1417b628b5a5 Mon Sep 17 00:00:00 2001 From: Jeroen De Dauw Date: Fri, 20 Sep 2019 14:37:17 +0200 Subject: [PATCH] Make tests package private Allows for https://github.com/DataValues/Common/pull/84 Wikibase Repo has 3 usages of StringValueParserTest: https://github.com/wikimedia/mediawiki-extensions-Wikibase/search?q=StringValueParserTest These can easily be fixed by using a copy of the class (or better yet: refactoring away from this inheritance abuse pattern). --- README.md | 3 ++- composer.json | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 7a40a59..e462a6c 100644 --- a/README.md +++ b/README.md @@ -57,9 +57,10 @@ employees for the [Wikidata project](https://wikidata.org/). ### 1.0.0 (dev) -* Added `TrimmingStringNormalizer` * Removed the `DATAVALUES_COMMON_VERSION` constant +* Classes in the `ValueParsers\Test` namespace are now package private. Notably `ValueParserTestBase` and `StringValueParserTest` * The `StringFormatter` constructor does not accept options any more +* Added `TrimmingStringNormalizer` ### 0.4.2 (2018-08-16) diff --git a/composer.json b/composer.json index 755a727..ac8cdb7 100644 --- a/composer.json +++ b/composer.json @@ -42,7 +42,9 @@ "DataValues\\": "src/DataValues/", "ValueFormatters\\": "src/ValueFormatters/", "ValueParsers\\": "src/ValueParsers/" - }, + } + }, + "autoload-dev": { "classmap": [ "tests/ValueParsers" ]