Skip to content

Commit 482be88

Browse files
shanssvgeesus
authored andcommitted
Resolved motion-position naming issue by renaming motion-position to motion-offset
1 parent 4430a58 commit 482be88

2 files changed

Lines changed: 26 additions & 29 deletions

File tree

motion-1/Overview.bs

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ Shortname: motion
77
Group: fxtf
88
Link Defaults: css-shapes-1 (type) <basic-shape>, css-transforms-1 (property) transform/transform-origin
99
Editor: Dirk Schulze, Adobe Systems Inc., dschulze@adobe.com
10+
Editor: Shane Stephens, Google, shanestephens@google.com
1011
Abstract: Motion paths allow authors to animate any graphical object along an author specified path.
1112
</pre>
1213

@@ -60,7 +61,7 @@ Media: visual
6061
Animatable: no
6162
</pre>
6263

63-
Specifies the <a>motion path</a> the element gets positioned at. The exact element's position on the motion path is determined by the 'motion-position' property. A <dfn>motion path</dfn> is either a specified path with one or multiple sub-paths or the geometry of a not styled basic shape. Each shape or path must define an <dfn>initial position</dfn> for the computed value of "0" for 'motion-position' and an <dfn>initial direction</dfn> which specifies the rotation of the object on the initial position.
64+
Specifies the <a>motion path</a> the element gets positioned at. The exact element's position on the motion path is determined by the 'motion-offset' property. A <dfn>motion path</dfn> is either a specified path with one or multiple sub-paths or the geometry of a not styled basic shape. Each shape or path must define an <dfn>initial position</dfn> for the computed value of "0" for 'motion-offset' and an <dfn>initial direction</dfn> which specifies the rotation of the object on the initial position.
6465

6566
In this specification a direction (or rotation) of 0 degree is equivalent to the direction of the positive x-axis in the object's <a>local coordinate system</a>. E.g a rotation of 0 degree points to the right side of the UA if the object and its ancestors have no transformation applied.
6667

@@ -103,10 +104,10 @@ For SVG elements without associated CSS layout box, the <a>used value</a> for <a
103104

104105
For elements with associated CSS layout box, the <a>used value</a> for <a value for=clip-path>fill-box</a>, <a value for=clip-path>stroke-box</a> and <a value for=clip-path>view-box</a> is <a value for=mask-clip>border-box</a>.
105106

106-
<h3 id="motion-position">Position on motion path: The 'motion-position' property</h3>
107+
<h3 id="motion-offset">Position on motion path: The 'motion-offset' property</h3>
107108

108109
<pre class='propdef'>
109-
Name: motion-position
110+
Name: motion-offset
110111
Value: <<length>> | <<percentage>>
111112
Initial: 0
112113
Applies to: All elements. In SVG, it applies to <a href="">container elements</a> excluding the <a href="">defs</a> element and all <a href="">graphics elements</a>
@@ -119,9 +120,7 @@ Animatable: yes
119120

120121
A distance that describes the position along the specified <a>motion path</a>.
121122

122-
ISSUE: Should the property be renamed to motion-distance or motion-progress instead? After all, the author defines a distance and not a point, even though the result will be an element positioned at the distance on the motion path.
123-
124-
<dl dfn-for="motion-position" dfn-type="value">
123+
<dl dfn-for="motion-offset" dfn-type="value">
125124
<dt><<percentage>></dt>
126125
<dt><<length>></dt>
127126
<dd>The distance from the <a>initial position</a> of the shape or path to the position of the element. Percentages are relative to the total path length including all sub-paths.</dd>
@@ -158,10 +157,10 @@ Values have the following meanings:
158157

159158
<dl dfn-for="mask-rotation" dfn-type="value">
160159
<dt><dfn>auto</dfn></dt>
161-
<dd>Indicates that the object is rotated (over time if 'motion-position' is animated) by the angle of the direction (i.e., directional tangent vector) of the <a>motion path</a>. If specified in combination with <<angle>>, the computed value of <<angle>> is added to the computed value of ''auto''.</dd>
160+
<dd>Indicates that the object is rotated (over time if 'motion-offset' is animated) by the angle of the direction (i.e., directional tangent vector) of the <a>motion path</a>. If specified in combination with <<angle>>, the computed value of <<angle>> is added to the computed value of ''auto''.</dd>
162161
<dt><dfn>reverse</dfn></dt>
163162
<dd>
164-
<p>Indicates that the object is rotated (over time if 'motion-position' is animated) by the angle of the direction (i.e., directional tangent vector) of the <a>motion path</a> plus 180 degrees. If specified in combination with <<angle>>, the computed value of <<angle>> is added to the computed value of ''reverse''.
163+
<p>Indicates that the object is rotated (over time if 'motion-offset' is animated) by the angle of the direction (i.e., directional tangent vector) of the <a>motion path</a> plus 180 degrees. If specified in combination with <<angle>>, the computed value of <<angle>> is added to the computed value of ''reverse''.
165164
<p class="note">This is the same as specifying ''auto 180deg''.
166165
</dd>
167166
<dt><<angle>></dt>
@@ -201,7 +200,7 @@ See the section <a href="#motion-processing">“Motion processing”</a> for how
201200

202201
<pre class='propdef'>
203202
Name: motion
204-
Value: &lt;'motion-path'> && &lt;'motion-position'> && &lt;'motion-rotation'>
203+
Value: &lt;'motion-path'> && &lt;'motion-offset'> && &lt;'motion-rotation'>
205204
Initial: see individual properties
206205
Applies to: All elements. In SVG, it applies to <a href="">container elements</a> excluding the <a href="">defs</a> element and all <a href="">graphics elements</a>
207206
Inherited: no
@@ -211,7 +210,7 @@ Media: visual
211210
Animatable: see individual properties
212211
</pre>
213212

214-
This is a shorthand property for setting 'motion-path', 'motion-position' and 'motion-rotation'. Omitted values are set to their initial values.
213+
This is a shorthand property for setting 'motion-path', 'motion-offset' and 'motion-rotation'. Omitted values are set to their initial values.
215214

216215
<h3 id="motion-processing">Motion processing</h3>
217216

@@ -221,7 +220,7 @@ This is a shorthand property for setting 'motion-path', 'motion-position' and 'm
221220
<ol>
222221
<li>Let <var>path</var> be the geometry of the specified basic shape, path or SVG <a href="">graphics element</a> reference.</li>
223222
<li>Let <var>totalLength</var> be the total length of <var>path</var> with all sub-paths.</li>
224-
<li>Let <var>distance</var> be the compute value of 'motion-position':
223+
<li>Let <var>distance</var> be the compute value of 'motion-offset':
225224
<dl class="switch">
226225
<dt>If <var>distance</var> is &lt; 0:</dt>
227226
<dd>Set <var>distance</var> to 0.</dd>

0 commit comments

Comments
 (0)