[css-highlight-api-1] Make HighlightRegistry maplike and remove name property from Highlight.

Author: sanketj

css-highlight-api-1/Overview.bs

@@ -103,7 +103,7 @@ Introduction</h2>
 			r.setStart(document.body, 0);
 			r.setEnd(document.body, 2);
 
-			CSS.highlights.add(new Highlight("example-highlight", r));
+			CSS.highlights.set("example-highlight", new Highlight(r));
 			</script>
 		</xmp>
 
@@ -139,7 +139,7 @@ Setting up Custom Highlights</h2>
 <h3 id=creation>
 Creating Custom Highlights</h3>
 
-	A <dfn>custom highlight</dfn> is a named collection of [=ranges=]
+	A <dfn>custom highlight</dfn> is a collection of [=ranges=]
 	representing portions of a document.
 	They do not necessarily fit into the element tree,
 	and can arbitrarily cross element boundaries without honoring its nesting structure.
@@ -160,35 +160,24 @@ Creating Custom Highlights</h3>
 	authors can chose between using {{Range}} objects and {{StaticRange}} objects.
 	See [[#range-invalidation]] for more details about this choice and its implications.
 
-	The <dfn for="custom highlight">name</dfn> of a [=custom highlight=]
-	is represented by its {{Highlight/name}} attribute,
-	which must be a valid <<ident-token>>.
-
 	<xmp class="idl">
 	[Exposed=Window]
 	interface Highlight {
-		constructor(CSSOMString name, AbstractRange... initialRanges);
+		constructor(AbstractRange... initialRanges);
 		setlike<AbstractRange>;
 		attribute long priority;
-		readonly attribute CSSOMString name;
 	};
 	</xmp>
 
 	See [[#priorities]] for more information on the {{Highlight/priority}} attribute.
 
 	<div algorithm="to create a custom highlight">
-		When the <dfn for=Highlight constructor>Highlight(CSSOMString name, AbstractRange... initialRanges)</dfn> constructor is invoked,
+		When the <dfn for=Highlight constructor>Highlight(AbstractRange... initialRanges)</dfn> constructor is invoked,
 		run the following steps:
 
 		<ol>
 			<li>
 				Let |highlight| be the new {{Highlight}} object.
-			<li>
-				If {{name!!argument}} does not [=CSS/parse=] as an <<ident-token>>, then [=throw=] a {{"SyntaxError"}}.
-			<li>
-				Let |nameArg| be the result of [=converted to an ECMAScript value|converting=] {{name!!argument}} to an ECMAScript value.
-			<li>
-				Set |highlight|'s {{Highlight/name}} to |nameArg|
 			<li>
 				Set |highlight|'s {{Highlight/priority}} to <code>0</code>.
 			<li>
@@ -206,13 +195,13 @@ Creating Custom Highlights</h3>
 Registering Custom Highlights</h3>
 
 	In order to have any effect,
-	[=custom highlights=] then needs to be
-	[=registered=] it into the [=highlight registry=].
+	[=custom highlights=] need to be
+	[=registered=] into the [=highlight registry=].
 
 	The <dfn>highlight registry</dfn> is accessed via the {{CSS/highlights}} attribute of the {{CSS}} namespace,
 	and represents all the [=custom highlights=] [=registered=] for the [=current global object=]’s [=associated Document=].
-	It is a [=setlike=], and can be updated using the usual methods.
-	It's [=set entries=] is initially empty.
+	It is a [=maplike=], and can be updated using the usual methods.
+	It's [=map entries=] is initially empty.
 
 	A [=custom highlight=] is said to be <dfn>registered</dfn>
 	if it is in the [=highlight registry=].
@@ -225,41 +214,35 @@ Registering Custom Highlights</h3>
 
 	[Exposed=Window]
 	interface HighlightRegistry {
-		setlike<Highlight>;
+		maplike<DOMString, Highlight>;
 	};
 	</xmp>
 
 	<div algorithm="to register a custom highlight">
 		To [=register=] a [=custom highlight=],
-		invoke the {{HighlightRegistry/add()}} method of the [=highlight registry=]
-		with the [=custom highlight=] as the argument.
-
-		When invoked,
-		the <dfn method for=HighlightRegistry>add(Highlight value)</dfn> method must run these steps:
-
-		1. If there is already a [=set entry=] with the same {{Highlight/name}} as the {{Highlight/name}} of {{value}},
-			then [=throw=] an {{"OperationError"}}.
-		3. Let |valueArg| be the result of [=converted to an ECMAScript value|converting=] {{value}} to an ECMAScript value.
-		4. Let |result| be the result of running [[webidl#es-add-delete|the steps for a built-in setlike add function]],
-			with the [=context object=] as the <code>this</code> value
-			and with |valueArg| as the argument.
-		5. Return |result|.
-	</div>
+		invoke the <code>set</code> method of the [=highlight registry=]
+		which will run [[webidl#es-map-set|the steps for a built-in maplike set function]],
+		with the [=context object=] as the <code>this</code> value,
+		the passed-in [=custom highlight name=] as |keyArg|,
+		and the passed-in highlight as |valueArg|.
+
+		The <dfn>custom highlight name</dfn> assigned to a [=custom highlight=] when it is [=registered=]
+		is used to identify the highlight during styling (see [[#styling-highlights]]).
 
 <h2 id=styling-highlights>
 Styling Custom Highlights</h2>
 
 <h3 id=custom-highlight-pseudo>
 The Custom Highlight Pseudo-element: ''::highlight()''</h3>
 
-	The <dfn>::highlight(<<highlight-name>>)</dfn> pseudo-element
+	The <dfn>::highlight(<<custom-highlight-name>>)</dfn> pseudo-element
 	(also known as the <dfn>custom highlight pseudo-element</dfn>)
 	represents the portion of a document that
 	is being [=contained=] or [=partially contained=]
 	in all the [=ranges=] of the [=registered=] [=custom highlight=]
-	with the [=custom highlight/name=] <<highlight-name>>,
+	with the [=custom highlight name=] <<custom-highlight-name>>,
 	if any.
-	<dfn type><<highlight-name>></dfn> must be a valid CSS <<ident-token>>.
+	<dfn type><<custom-highlight-name>></dfn> must be a valid CSS <<ident-token>>.
 
 
 <h3 id=processing-model>
@@ -317,7 +300,7 @@ Painting</h4>
 						r2.setStart(textNode, 3);
 						r2.setEnd(textNode, 7);
 
-						CSS.highlights.add(new Highlight("sample", r1, r2));
+						CSS.highlights.set("sample", new Highlight(r1, r2));
 					</script>
 				</xmp>